Skip to content

Commit 3eaaefb

Browse files
committed
Updating four tests to use visible labels only.
1 parent 763502e commit 3eaaefb

File tree

4 files changed

+9
-5
lines changed

4 files changed

+9
-5
lines changed

test/functional/apps/dashboard/dashboard_clone.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,8 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
4040
await PageObjects.dashboard.loadSavedDashboard(clonedDashboardName);
4141
await retry.try(async () => {
4242
const panelTitles = await PageObjects.dashboard.getPanelTitles();
43-
expect(panelTitles).to.eql(PageObjects.dashboard.getTestVisualizationNames());
43+
const visiblePanelTitles = panelTitles.map((title) => title.split('\n')[1]);
44+
expect(visiblePanelTitles).to.eql(PageObjects.dashboard.getTestVisualizationNames());
4445
});
4546
});
4647

test/functional/apps/dashboard/edit_embeddable_redirects.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -67,7 +67,8 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
6767
const newPanelCount = await PageObjects.dashboard.getPanelCount();
6868
expect(newPanelCount).to.eql(originalPanelCount + 1);
6969
const titles = await PageObjects.dashboard.getPanelTitles();
70-
expect(titles.indexOf(newTitle)).to.not.be(-1);
70+
const visibleTitles = titles.map((title) => title.split('\n')[1]);
71+
expect(visibleTitles.indexOf(newTitle)).to.not.be(-1);
7172
});
7273

7374
it('loses originatingApp connection after save as when redirectToOrigin is false', async () => {

test/functional/apps/dashboard/panel_replacing.ts

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -65,8 +65,9 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
6565
await PageObjects.header.waitUntilLoadingHasFinished();
6666
await PageObjects.dashboard.waitForRenderComplete();
6767
const panelTitles = await PageObjects.dashboard.getPanelTitles();
68-
expect(panelTitles.length).to.be(2);
69-
expect(panelTitles[0]).to.be(AREA_CHART_VIS_NAME);
68+
const visiblePanelTitles = panelTitles.map((title) => title.split('\n')[1]);
69+
expect(visiblePanelTitles.length).to.be(2);
70+
expect(visiblePanelTitles[0]).to.be(AREA_CHART_VIS_NAME);
7071
});
7172

7273
it('replaced panel with saved search', async () => {

test/functional/apps/management/_index_pattern_create_delete.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -111,7 +111,8 @@ export default function ({ getService, getPageObjects }) {
111111

112112
const comparedHeaders = headers.map(function compareHead(header, i) {
113113
return header.getVisibleText().then(function (text) {
114-
expect(text).to.be(expectedHeaders[i]);
114+
const visibleText = text.split('\n')[1];
115+
expect(visibleText).to.be(expectedHeaders[i]);
115116
});
116117
});
117118

0 commit comments

Comments
 (0)