Skip to content

Commit 3759063

Browse files
authored
remove legacy ES plugin (#77703)
* remove legacy ES plug * fix types * delete some `legacy/core_plugins` references * fix type
1 parent eb825db commit 3759063

File tree

42 files changed

+53
-944
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

42 files changed

+53
-944
lines changed

.github/CODEOWNERS

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,6 @@
5959
# APM
6060
/x-pack/plugins/apm/ @elastic/apm-ui
6161
/x-pack/test/functional/apps/apm/ @elastic/apm-ui
62-
/src/legacy/core_plugins/apm_oss/ @elastic/apm-ui
6362
/src/plugins/apm_oss/ @elastic/apm-ui
6463
/src/apm.js @watson @vigneshshanmugam
6564

@@ -83,9 +82,6 @@
8382
/src/plugins/home/public @elastic/kibana-core-ui
8483
/src/plugins/home/server/*.ts @elastic/kibana-core-ui
8584
/src/plugins/home/server/services/ @elastic/kibana-core-ui
86-
# Exclude tutorial resources folder for now because they are not owned by Kibana app and most will move out soon
87-
/src/legacy/core_plugins/kibana/public/home/*.ts @elastic/kibana-core-ui
88-
/src/legacy/core_plugins/kibana/public/home/np_ready/ @elastic/kibana-core-ui
8985
/x-pack/plugins/global_search_bar/ @elastic/kibana-core-ui
9086

9187
# Observability UIs
@@ -285,7 +281,6 @@ x-pack/plugins/telemetry_collection_xpack/schema/xpack_plugins.json @elastic/kib
285281
# Core design
286282
/src/plugins/dashboard/**/*.scss @elastic/kibana-core-ui-designers
287283
/x-pack/plugins/canvas/**/*.scss @elastic/kibana-core-ui-designers
288-
/src/legacy/core_plugins/kibana/public/home/**/*.scss @elastic/kibana-core-ui-designers
289284
/x-pack/legacy/plugins/spaces/**/*.scss @elastic/kibana-core-ui-designers
290285
/x-pack/plugins/spaces/**/*.scss @elastic/kibana-core-ui-designers
291286
/x-pack/plugins/security/**/*.scss @elastic/kibana-core-ui-designers

kibana.d.ts

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,6 @@ export { Public, Server };
2828
/**
2929
* All exports from TS ambient definitions (where types are added for JS source in a .d.ts file).
3030
*/
31-
import * as LegacyElasticsearch from './src/legacy/core_plugins/elasticsearch';
3231
import * as LegacyKibanaPluginSpec from './src/legacy/plugin_discovery/plugin_spec/plugin_spec_options';
3332
import * as LegacyKibanaServer from './src/legacy/server/kbn_server';
3433

@@ -44,13 +43,4 @@ export namespace Legacy {
4443
export type InitPluginFunction = LegacyKibanaPluginSpec.InitPluginFunction;
4544
export type UiExports = LegacyKibanaPluginSpec.UiExports;
4645
export type PluginSpecOptions = LegacyKibanaPluginSpec.PluginSpecOptions;
47-
48-
export namespace Plugins {
49-
export namespace elasticsearch {
50-
export type Plugin = LegacyElasticsearch.ElasticsearchPlugin;
51-
export type Cluster = LegacyElasticsearch.Cluster;
52-
export type ClusterConfig = LegacyElasticsearch.ClusterConfig;
53-
export type CallClusterOptions = LegacyElasticsearch.CallClusterOptions;
54-
}
55-
}
5646
}

src/cli/cluster/cluster_manager.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -224,7 +224,6 @@ export class ClusterManager {
224224
new Set(
225225
[
226226
fromRoot('src/core'),
227-
fromRoot('src/legacy/core_plugins'),
228227
fromRoot('src/legacy/server'),
229228
fromRoot('src/legacy/ui'),
230229
fromRoot('src/legacy/utils'),

src/cli/serve/serve.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -178,7 +178,7 @@ export default function (program) {
178178
'A path to scan for plugins, this can be specified multiple ' +
179179
'times to specify multiple directories',
180180
pluginDirCollector,
181-
[fromRoot('plugins'), fromRoot('src/legacy/core_plugins')]
181+
[fromRoot('plugins')]
182182
)
183183
.option(
184184
'--plugin-path <path>',

src/dev/jest/config.js

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,6 @@ export default {
2525
'<rootDir>/src/plugins',
2626
'<rootDir>/src/legacy/ui',
2727
'<rootDir>/src/core',
28-
'<rootDir>/src/legacy/core_plugins',
2928
'<rootDir>/src/legacy/server',
3029
'<rootDir>/src/cli',
3130
'<rootDir>/src/cli_keystore',
@@ -51,14 +50,11 @@ export default {
5150
'packages/kbn-ui-framework/src/services/**/*.js',
5251
'!packages/kbn-ui-framework/src/services/index.js',
5352
'!packages/kbn-ui-framework/src/services/**/*/index.js',
54-
'src/legacy/core_plugins/**/*.{js,mjs,jsx,ts,tsx}',
55-
'!src/legacy/core_plugins/**/{__test__,__snapshots__}/**/*',
5653
],
5754
moduleNameMapper: {
5855
'@elastic/eui$': '<rootDir>/node_modules/@elastic/eui/test-env',
5956
'@elastic/eui/lib/(.*)?': '<rootDir>/node_modules/@elastic/eui/test-env/$1',
6057
'^src/plugins/(.*)': '<rootDir>/src/plugins/$1',
61-
'^plugins/([^/.]*)(.*)': '<rootDir>/src/legacy/core_plugins/$1/public$2',
6258
'^uiExports/(.*)': '<rootDir>/src/dev/jest/mocks/file_mock.js',
6359
'^test_utils/(.*)': '<rootDir>/src/test_utils/public/$1',
6460
'^fixtures/(.*)': '<rootDir>/src/fixtures/$1',

src/dev/precommit_hook/casing_check_config.js

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -132,11 +132,6 @@ export const REMOVE_EXTENSION = ['packages/kbn-plugin-generator/template/**/*.ej
132132
* @type {Array}
133133
*/
134134
export const TEMPORARILY_IGNORED_PATHS = [
135-
'src/legacy/core_plugins/console/public/src/directives/helpExample.txt',
136-
'src/legacy/core_plugins/console/public/src/sense_editor/theme-sense-dark.js',
137-
'src/legacy/core_plugins/tile_map/public/__tests__/scaledCircleMarkers.png',
138-
'src/legacy/core_plugins/tile_map/public/__tests__/shadedCircleMarkers.png',
139-
'src/legacy/core_plugins/tile_map/public/__tests__/shadedGeohashGrid.png',
140135
'src/fixtures/config_upgrade_from_4.0.0_to_4.0.1-snapshot.json',
141136
'src/core/server/core_app/assets/favicons/android-chrome-192x192.png',
142137
'src/core/server/core_app/assets/favicons/android-chrome-256x256.png',

0 commit comments

Comments
 (0)