cleaned up subscription with take(1) and fixed an oops

Author: ThomThomson

src/plugins/embeddable/public/lib/actions/edit_panel_action.ts

@@ -20,6 +20,7 @@
 import { i18n } from '@kbn/i18n';
 import { ApplicationStart } from 'kibana/public';
 import { Action } from 'src/plugins/ui_actions/public';
+import { take } from 'rxjs/operators';
 import { ViewMode } from '../types';
 import { EmbeddableFactoryNotFoundError } from '../errors';
 import { EmbeddableStart } from '../../plugin';
@@ -42,9 +43,9 @@ export class EditPanelAction implements Action<ActionContext> {
     private readonly application: ApplicationStart
   ) {
     if (this.application?.currentAppId$) {
-      this.application.currentAppId$.subscribe(
-        (appId: string | undefined) => (this.currentAppId = appId)
-      );
+      this.application.currentAppId$
+        .pipe(take(1))
+        .subscribe((appId: string | undefined) => (this.currentAppId = appId));
     }
   }
 

test/functional/apps/visualize/_pie_chart.js

@@ -210,10 +210,8 @@ export default function({ getService, getPageObjects }) {
       });
 
       it('should correctly save disabled agg', async () => {
-        console.log('GONNA S A V E  OUR BOI AND EXPECT SUCCESS AND BREADCRUMB');
         await PageObjects.visualize.saveVisualizationExpectSuccessAndBreadcrumb(vizName1);
 
-        console.log('NOW GONNA LOAD UP THAT SAVED VIS ALL NICE');
         await PageObjects.visualize.loadSavedVisualization(vizName1);
         await PageObjects.visChart.waitForRenderingCount();