Skip to content

Commit 2e6dca6

Browse files
Uptime overview overhaul (#83406)
Co-authored-by: Kibana Machine <[email protected]>
1 parent 668ec44 commit 2e6dca6

40 files changed

+1126
-786
lines changed

x-pack/plugins/translations/translations/ja-JP.json

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -20634,11 +20634,8 @@
2063420634
"xpack.uptime.monitorList.defineConnector.description": "アラートを有効にするには、デフォルトのアラートアクションコネクターを定義してください。",
2063520635
"xpack.uptime.monitorList.disableDownAlert": "ステータスアラートを無効にする",
2063620636
"xpack.uptime.monitorList.downLineSeries.downLabel": "ダウン",
20637-
"xpack.uptime.monitorList.drawer.locations.statusDown": "{locations}でダウン",
20638-
"xpack.uptime.monitorList.drawer.locations.statusUp": "{locations}でアップ",
2063920637
"xpack.uptime.monitorList.drawer.missingLocation": "一部のHeartbeatインスタンスには位置情報が定義されていません。Heartbeat構成への{link}。",
2064020638
"xpack.uptime.monitorList.enabledAlerts.noAlert": "このモニターではアラートが有効ではありません。",
20641-
"xpack.uptime.monitorList.enabledAlerts.title": "有効なアラート:",
2064220639
"xpack.uptime.monitorList.enableDownAlert": "ステータスアラートを有効にする",
2064320640
"xpack.uptime.monitorList.expandDrawerButton.ariaLabel": "ID {id}のモニターの行を展開",
2064420641
"xpack.uptime.monitorList.geoName.helpLinkAnnotation": "場所を追加",

x-pack/plugins/translations/translations/zh-CN.json

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -20654,11 +20654,8 @@
2065420654
"xpack.uptime.monitorList.defineConnector.description": "要开始启用告警,请在以下位置定义默认告警操作连接器",
2065520655
"xpack.uptime.monitorList.disableDownAlert": "禁用状态告警",
2065620656
"xpack.uptime.monitorList.downLineSeries.downLabel": "关闭",
20657-
"xpack.uptime.monitorList.drawer.locations.statusDown": "在 {locations} 已关闭",
20658-
"xpack.uptime.monitorList.drawer.locations.statusUp": "在 {locations} 正运行",
2065920657
"xpack.uptime.monitorList.drawer.missingLocation": "某些 Heartbeat 实例未定义位置。{link}到您的 Heartbeat 配置。",
2066020658
"xpack.uptime.monitorList.enabledAlerts.noAlert": "没有为此监测启用告警。",
20661-
"xpack.uptime.monitorList.enabledAlerts.title": "已启用的告警:",
2066220659
"xpack.uptime.monitorList.enableDownAlert": "启用状态告警",
2066320660
"xpack.uptime.monitorList.expandDrawerButton.ariaLabel": "展开 ID {id} 的监测行",
2066420661
"xpack.uptime.monitorList.geoName.helpLinkAnnotation": "添加位置",

x-pack/plugins/uptime/common/runtime_types/monitor/state.ts

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -23,9 +23,14 @@ export const StateType = t.intersection([
2323
up: t.number,
2424
down: t.number,
2525
}),
26-
monitor: t.partial({
27-
name: t.string,
28-
}),
26+
monitor: t.intersection([
27+
t.partial({
28+
name: t.string,
29+
}),
30+
t.type({
31+
type: t.string,
32+
}),
33+
]),
2934
}),
3035
t.partial({
3136
tls: t.partial({

x-pack/plugins/uptime/public/apps/uptime_app.tsx

Lines changed: 22 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -32,9 +32,11 @@ import {
3232
import { store } from '../state';
3333
import { kibanaService } from '../state/kibana_service';
3434
import { ScopedHistory } from '../../../../../src/core/public';
35+
import { EuiThemeProvider } from '../../../observability/public';
3536

3637
export interface UptimeAppColors {
3738
danger: string;
39+
dangerBehindText: string;
3840
success: string;
3941
gray: string;
4042
range: string;
@@ -103,24 +105,26 @@ const Application = (props: UptimeAppProps) => {
103105
services={{ ...core, ...plugins, triggersActionsUi: startPlugins.triggersActionsUi }}
104106
>
105107
<Router history={props.history}>
106-
<UptimeRefreshContextProvider>
107-
<UptimeSettingsContextProvider {...props}>
108-
<UptimeThemeContextProvider darkMode={darkMode}>
109-
<UptimeStartupPluginsContextProvider {...startPlugins}>
110-
<UptimeAlertsContextProvider>
111-
<EuiPage className="app-wrapper-panel " data-test-subj="uptimeApp">
112-
<RedirectAppLinks application={core.application}>
113-
<main>
114-
<UptimeAlertsFlyoutWrapper />
115-
<PageRouter />
116-
</main>
117-
</RedirectAppLinks>
118-
</EuiPage>
119-
</UptimeAlertsContextProvider>
120-
</UptimeStartupPluginsContextProvider>
121-
</UptimeThemeContextProvider>
122-
</UptimeSettingsContextProvider>
123-
</UptimeRefreshContextProvider>
108+
<EuiThemeProvider darkMode={darkMode}>
109+
<UptimeRefreshContextProvider>
110+
<UptimeSettingsContextProvider {...props}>
111+
<UptimeThemeContextProvider darkMode={darkMode}>
112+
<UptimeStartupPluginsContextProvider {...startPlugins}>
113+
<UptimeAlertsContextProvider>
114+
<EuiPage className="app-wrapper-panel " data-test-subj="uptimeApp">
115+
<RedirectAppLinks application={core.application}>
116+
<main>
117+
<UptimeAlertsFlyoutWrapper />
118+
<PageRouter />
119+
</main>
120+
</RedirectAppLinks>
121+
</EuiPage>
122+
</UptimeAlertsContextProvider>
123+
</UptimeStartupPluginsContextProvider>
124+
</UptimeThemeContextProvider>
125+
</UptimeSettingsContextProvider>
126+
</UptimeRefreshContextProvider>
127+
</EuiThemeProvider>
124128
</Router>
125129
</KibanaContextProvider>
126130
</ReduxProvider>

x-pack/plugins/uptime/public/components/monitor/status_details/status_bar/ssl_certificate.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ import { FormattedMessage } from '@kbn/i18n/react';
1111
import { Tls, X509Expiry } from '../../../../../common/runtime_types';
1212
import { CERTIFICATES_ROUTE } from '../../../../../common/constants';
1313
import { MonListDescription, MonListTitle } from './status_bar';
14-
import { CertStatusColumn } from '../../../overview/monitor_list/cert_status_column';
14+
import { CertStatusColumn } from '../../../overview/monitor_list/columns/cert_status_column';
1515

1616
interface Props {
1717
/**

x-pack/plugins/uptime/public/components/overview/filter_group/filter_popover.tsx

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -54,6 +54,7 @@ export const FilterPopover = ({
5454
const mItems = selectedItems.concat(allItems ?? []);
5555
const newItems = mItems.filter((item, index) => mItems.indexOf(item) === index);
5656
setItems(newItems);
57+
setTempSelectedItems(selectedItems);
5758
}, [allItems, selectedItems]);
5859

5960
useEffect(() => {
@@ -73,7 +74,7 @@ export const FilterPopover = ({
7374
isDisabled={disabled && selectedItems.length === 0}
7475
isSelected={tempSelectedItems.length > 0}
7576
numFilters={items.length}
76-
numActiveFilters={tempSelectedItems.length}
77+
numActiveFilters={isOpen ? tempSelectedItems.length : selectedItems.length}
7778
onClick={() => {
7879
setIsOpen(!isOpen);
7980
onFilterFieldChange(fieldName, tempSelectedItems);

0 commit comments

Comments
 (0)