Skip to content

Commit 2c7099a

Browse files
ensure mml validation works as expected
1 parent c14e344 commit 2c7099a

File tree

1 file changed

+4
-2
lines changed
  • x-pack/plugins/ml/public/application/data_frame_analytics/pages/analytics_management/hooks/use_create_analytics_form

1 file changed

+4
-2
lines changed

x-pack/plugins/ml/public/application/data_frame_analytics/pages/analytics_management/hooks/use_create_analytics_form/reducer.ts

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -425,13 +425,15 @@ const validateForm = (state: State): State => {
425425
dependentVariable === '';
426426

427427
const mmlValidationResult = validateMml(estimatedModelMemoryLimit, modelMemoryLimit);
428-
const mmlInvalid = mmlValidationResult !== null && mmlValidationResult.invalidUnits !== undefined;
428+
const mmlInvalid =
429+
mmlValidationResult !== null &&
430+
(mmlValidationResult.invalidUnits !== undefined || mmlValidationResult.required === true);
429431

430432
state.form.modelMemoryLimitValidationResult = mmlValidationResult;
431433

432434
state.isValid =
433435
!jobTypeEmpty &&
434-
mmlInvalid &&
436+
!mmlInvalid &&
435437
!jobIdEmpty &&
436438
jobIdValid &&
437439
!jobIdExists &&

0 commit comments

Comments
 (0)