Commit 233da45
# Backport
This will backport the following commits from `main` to `8.x`:
- [[Security Solution][Alert Details] - fix some UI issues related to
emotion/css vs emotion/react
(#205664)](#205664)
<!--- Backport version: 9.4.3 -->
### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)
<!--BACKPORT [{"author":{"name":"Philippe
Oberti","email":"[email protected]"},"sourceCommit":{"committedDate":"2025-01-08T16:00:28Z","message":"[Security
Solution][Alert Details] - fix some UI issues related to emotion/css vs
emotion/react (#205664)\n\n## Summary\r\n\r\nThis recent
[PR](#205011) slightly\r\nbroke
the UI in a couple of small places in the alert details
flyout.\r\nStrangely, I did review the PR by pulling down the branch,
but only\r\nlooked at the places that were impacted by the files
modified. The\r\ncouple of places where the UI broke were completely
different...\r\nMy guess it is is related to the fact that in those
place we were still\r\nusing `@emotion/css` and this might not play nice
with some\r\n`styled_components`...\r\n\r\nUpdating those places to use
`@emotion/react` fixed the issues!\r\n\r\n| Before fix | After fix
|\r\n| ------------- | -------------
|\r\n|\r\n\r\n|\r\n\r\n|\r\n\r\n|
Before fix | After fix |\r\n| ------------- | -------------
|\r\n|\r\n\r\n|\r\n\r\n|\r\n\r\n|
Before fix | After fix |\r\n| ------------- | -------------
|\r\n|\r\n\r\n|\r\n\r\n|\r\n\r\nIn
a follow work, we need to remove completely all
the\r\n`styled_components` we
have.","sha":"a8e1bf46a3dc111e37caf19b19897081ed2a8078","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team:Threat
Hunting:Investigations","backport:version","v8.18.0"],"title":"[Security
Solution][Alert Details] - fix some UI issues related to emotion/css vs
emotion/react","number":205664,"url":"https://github.com/elastic/kibana/pull/205664","mergeCommit":{"message":"[Security
Solution][Alert Details] - fix some UI issues related to emotion/css vs
emotion/react (#205664)\n\n## Summary\r\n\r\nThis recent
[PR](#205011) slightly\r\nbroke
the UI in a couple of small places in the alert details
flyout.\r\nStrangely, I did review the PR by pulling down the branch,
but only\r\nlooked at the places that were impacted by the files
modified. The\r\ncouple of places where the UI broke were completely
different...\r\nMy guess it is is related to the fact that in those
place we were still\r\nusing `@emotion/css` and this might not play nice
with some\r\n`styled_components`...\r\n\r\nUpdating those places to use
`@emotion/react` fixed the issues!\r\n\r\n| Before fix | After fix
|\r\n| ------------- | -------------
|\r\n|\r\n\r\n|\r\n\r\n|\r\n\r\n|
Before fix | After fix |\r\n| ------------- | -------------
|\r\n|\r\n\r\n|\r\n\r\n|\r\n\r\n|
Before fix | After fix |\r\n| ------------- | -------------
|\r\n|\r\n\r\n|\r\n\r\n|\r\n\r\nIn
a follow work, we need to remove completely all
the\r\n`styled_components` we
have.","sha":"a8e1bf46a3dc111e37caf19b19897081ed2a8078"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/205664","number":205664,"mergeCommit":{"message":"[Security
Solution][Alert Details] - fix some UI issues related to emotion/css vs
emotion/react (#205664)\n\n## Summary\r\n\r\nThis recent
[PR](#205011) slightly\r\nbroke
the UI in a couple of small places in the alert details
flyout.\r\nStrangely, I did review the PR by pulling down the branch,
but only\r\nlooked at the places that were impacted by the files
modified. The\r\ncouple of places where the UI broke were completely
different...\r\nMy guess it is is related to the fact that in those
place we were still\r\nusing `@emotion/css` and this might not play nice
with some\r\n`styled_components`...\r\n\r\nUpdating those places to use
`@emotion/react` fixed the issues!\r\n\r\n| Before fix | After fix
|\r\n| ------------- | -------------
|\r\n|\r\n\r\n|\r\n\r\n|\r\n\r\n|
Before fix | After fix |\r\n| ------------- | -------------
|\r\n|\r\n\r\n|\r\n\r\n|\r\n\r\n|
Before fix | After fix |\r\n| ------------- | -------------
|\r\n|\r\n\r\n|\r\n\r\n|\r\n\r\nIn
a follow work, we need to remove completely all
the\r\n`styled_components` we
have.","sha":"a8e1bf46a3dc111e37caf19b19897081ed2a8078"}},{"branch":"8.x","label":"v8.18.0","branchLabelMappingKey":"^v8.18.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->
Co-authored-by: Philippe Oberti <[email protected]>
1 parent 1429560 commit 233da45
File tree
6 files changed
+14
-10
lines changed- x-pack/solutions/security/plugins/security_solution/public/flyout
- document_details
- right/components
6 files changed
+14
-10
lines changedLines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
15 | 15 | | |
16 | 16 | | |
17 | 17 | | |
18 | | - | |
| 18 | + | |
19 | 19 | | |
20 | 20 | | |
21 | 21 | | |
| |||
Lines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
15 | 15 | | |
16 | 16 | | |
17 | 17 | | |
18 | | - | |
| 18 | + | |
19 | 19 | | |
20 | 20 | | |
21 | 21 | | |
| |||
Lines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
6 | 6 | | |
7 | 7 | | |
8 | 8 | | |
9 | | - | |
| 9 | + | |
10 | 10 | | |
11 | 11 | | |
12 | 12 | | |
| |||
Lines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
8 | 8 | | |
9 | 9 | | |
10 | 10 | | |
11 | | - | |
| 11 | + | |
12 | 12 | | |
13 | 13 | | |
14 | 14 | | |
| |||
Lines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
8 | 8 | | |
9 | 9 | | |
10 | 10 | | |
11 | | - | |
| 11 | + | |
12 | 12 | | |
13 | 13 | | |
14 | 14 | | |
| |||
Lines changed: 9 additions & 5 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
20 | 20 | | |
21 | 21 | | |
22 | 22 | | |
| 23 | + | |
23 | 24 | | |
24 | 25 | | |
25 | 26 | | |
| |||
126 | 127 | | |
127 | 128 | | |
128 | 129 | | |
| 130 | + | |
129 | 131 | | |
130 | 132 | | |
131 | 133 | | |
| |||
159 | 161 | | |
160 | 162 | | |
161 | 163 | | |
162 | | - | |
163 | | - | |
| 164 | + | |
| 165 | + | |
164 | 166 | | |
165 | 167 | | |
166 | 168 | | |
| |||
178 | 180 | | |
179 | 181 | | |
180 | 182 | | |
| 183 | + | |
| 184 | + | |
| 185 | + | |
181 | 186 | | |
182 | 187 | | |
183 | 188 | | |
184 | 189 | | |
185 | | - | |
186 | 190 | | |
187 | | - | |
188 | | - | |
| 191 | + | |
189 | 192 | | |
| 193 | + | |
190 | 194 | | |
191 | 195 | | |
192 | 196 | | |
| |||
0 commit comments