Skip to content

Commit 1ecc340

Browse files
[Security Solutions] Remove commented out old linter rules (#94753) (#94765)
## Summary Cleanup .. * Removes commented out old linter rules from 2+ years ago. The project is very large and a lot of people are in the code base now and the comments are not relevant. * Removes ts config optimize we don't use anymore * Removes old script for rules we don't use anymore with elastic searches. Co-authored-by: Frank Hassanabad <[email protected]>
1 parent eb51fd4 commit 1ecc340

File tree

10 files changed

+0
-440
lines changed

10 files changed

+0
-440
lines changed

.eslintrc.js

Lines changed: 0 additions & 60 deletions
Original file line numberDiff line numberDiff line change
@@ -832,48 +832,12 @@ module.exports = {
832832
// typescript only for front and back end
833833
files: ['x-pack/plugins/security_solution/**/*.{ts,tsx}'],
834834
rules: {
835-
// This will be turned on after bug fixes are complete
836-
// '@typescript-eslint/explicit-member-accessibility': 'warn',
837835
'@typescript-eslint/no-this-alias': 'error',
838836
'@typescript-eslint/no-explicit-any': 'error',
839837
'@typescript-eslint/no-useless-constructor': 'error',
840-
// This will be turned on after bug fixes are complete
841-
// '@typescript-eslint/no-object-literal-type-assertion': 'warn',
842838
'@typescript-eslint/unified-signatures': 'error',
843-
844-
// eventually we want this to be a warn and then an error since this is a recommended linter rule
845-
// for now, keeping it commented out to avoid too much IDE noise until the other linter issues
846-
// are fixed in the next release or two
847-
// '@typescript-eslint/explicit-function-return-type': 'warn',
848-
849-
// these rules cannot be turned on and tested at the moment until this issue is resolved:
850-
// https://github.com/prettier/prettier-eslint/issues/201
851-
// '@typescript-eslint/await-thenable': 'error',
852-
// '@typescript-eslint/no-non-null-assertion': 'error'
853-
// '@typescript-eslint/no-unnecessary-type-assertion': 'error',
854-
// '@typescript-eslint/no-unused-vars': 'error',
855-
// '@typescript-eslint/prefer-includes': 'error',
856-
// '@typescript-eslint/prefer-string-starts-ends-with': 'error',
857-
// '@typescript-eslint/promise-function-async': 'error',
858-
// '@typescript-eslint/prefer-regexp-exec': 'error',
859-
// '@typescript-eslint/promise-function-async': 'error',
860-
// '@typescript-eslint/require-array-sort-compare': 'error',
861-
// '@typescript-eslint/restrict-plus-operands': 'error',
862-
// '@typescript-eslint/unbound-method': 'error',
863839
},
864840
},
865-
// {
866-
// // will introduced after the other warns are fixed
867-
// // typescript and javascript for front end react performance
868-
// files: ['x-pack/plugins/security_solution/public/**/!(*.test).{js,mjs,ts,tsx}'],
869-
// plugins: ['react-perf'],
870-
// rules: {
871-
// // 'react-perf/jsx-no-new-object-as-prop': 'error',
872-
// // 'react-perf/jsx-no-new-array-as-prop': 'error',
873-
// // 'react-perf/jsx-no-new-function-as-prop': 'error',
874-
// // 'react/jsx-no-bind': 'error',
875-
// },
876-
// },
877841
{
878842
// typescript and javascript for front and back end
879843
files: ['x-pack/plugins/security_solution/**/*.{js,mjs,ts,tsx}'],
@@ -886,21 +850,6 @@ module.exports = {
886850
'array-callback-return': 'error',
887851
'no-array-constructor': 'error',
888852
complexity: 'warn',
889-
// This will be turned on after bug fixes are mostly completed
890-
// 'consistent-return': 'warn',
891-
// This will be turned on after bug fixes are mostly completed
892-
// 'func-style': ['warn', 'expression'],
893-
// These will be turned on after bug fixes are mostly completed and we can
894-
// run a fix-lint
895-
/*
896-
'import/order': [
897-
'warn',
898-
{
899-
groups: ['builtin', 'external', 'internal', 'parent', 'sibling', 'index'],
900-
'newlines-between': 'always',
901-
},
902-
],
903-
*/
904853
'node/no-deprecated-api': 'error',
905854
'no-bitwise': 'error',
906855
'no-continue': 'error',
@@ -940,12 +889,8 @@ module.exports = {
940889
'no-useless-catch': 'error',
941890
'no-useless-concat': 'error',
942891
'no-useless-computed-key': 'error',
943-
// This will be turned on after bug fixes are mostly complete
944-
// 'no-useless-escape': 'warn',
945892
'no-useless-rename': 'error',
946893
'no-useless-return': 'error',
947-
// This will be turned on after bug fixers are mostly complete
948-
// 'no-void': 'warn',
949894
'one-var-declaration-per-line': 'error',
950895
'prefer-object-spread': 'error',
951896
'prefer-promise-reject-errors': 'error',
@@ -961,9 +906,6 @@ module.exports = {
961906
'react/no-danger-with-children': 'error',
962907
'react/no-deprecated': 'error',
963908
'react/no-did-mount-set-state': 'error',
964-
// Re-enable once we have better options per this issue:
965-
// https://github.com/airbnb/javascript/issues/1875
966-
// 'react/no-did-update-set-state': 'error',
967909
'react/no-direct-mutation-state': 'error',
968910
'react/no-find-dom-node': 'error',
969911
'react/no-redundant-should-component-update': 'error',
@@ -975,8 +917,6 @@ module.exports = {
975917
'react/no-unsafe': 'error',
976918
'react/no-unused-prop-types': 'error',
977919
'react/no-unused-state': 'error',
978-
// will introduced after the other warns are fixed
979-
// 'react/sort-comp': 'error',
980920
'react/void-dom-elements-no-children': 'error',
981921
'react/jsx-no-comment-textnodes': 'error',
982922
'react/jsx-no-literals': 'error',

x-pack/plugins/security_solution/scripts/convert_saved_search_to_rules.js

Lines changed: 0 additions & 177 deletions
This file was deleted.

x-pack/plugins/security_solution/scripts/optimize_tsconfig.js

Lines changed: 0 additions & 14 deletions
This file was deleted.

x-pack/plugins/security_solution/scripts/optimize_tsconfig/README.md

Lines changed: 0 additions & 16 deletions
This file was deleted.

x-pack/plugins/security_solution/scripts/optimize_tsconfig/optimize.js

Lines changed: 0 additions & 77 deletions
This file was deleted.

0 commit comments

Comments
 (0)