Merge branch 'master' into ml-migrate-router-fix-management

Author: walterra

.ci/Dockerfile

@@ -0,0 +1,38 @@
+# NOTE: This Dockerfile is ONLY used to run certain tasks in CI. It is not used to run Kibana or as a distributable.
+# If you're looking for the Kibana Docker image distributable, please see: src/dev/build/tasks/os_packages/docker_generator/templates/dockerfile.template.ts
+
+ARG NODE_VERSION=10.21.0
+
+FROM node:${NODE_VERSION} AS base
+
+RUN apt-get update && \
+    apt-get -y install xvfb gconf-service libasound2 libatk1.0-0 libc6 libcairo2 libcups2 \
+      libdbus-1-3 libexpat1 libfontconfig1 libgcc1 libgconf-2-4 libgdk-pixbuf2.0-0 libglib2.0-0 \
+      libgtk-3-0 libnspr4 libpango-1.0-0 libpangocairo-1.0-0 libstdc++6 libx11-6 libx11-xcb1 libxcb1 \
+      libxcomposite1 libxcursor1 libxdamage1 libxext6 libxfixes3 libxi6 libxrandr2 libxrender1 libxss1 \
+      libxtst6 ca-certificates fonts-liberation libappindicator1 libnss3 lsb-release xdg-utils wget openjdk-8-jre && \
+    rm -rf /var/lib/apt/lists/*
+
+RUN curl -sSL https://dl.google.com/linux/linux_signing_key.pub | apt-key add - \
+  && sh -c 'echo "deb [arch=amd64] http://dl.google.com/linux/chrome/deb/ stable main" >> /etc/apt/sources.list.d/google.list' \
+  && apt-get update \
+  && apt-get install -y rsync jq bsdtar google-chrome-stable \
+  --no-install-recommends \
+  && rm -rf /var/lib/apt/lists/* /tmp/* /var/tmp/*
+
+RUN LATEST_VAULT_RELEASE=$(curl -s https://api.github.com/repos/hashicorp/vault/tags | jq --raw-output .[0].name[1:]) \
+  && curl -L https://releases.hashicorp.com/vault/${LATEST_VAULT_RELEASE}/vault_${LATEST_VAULT_RELEASE}_linux_amd64.zip -o vault.zip \
+  && unzip vault.zip \
+  && rm vault.zip \
+  && chmod +x vault \
+  && mv vault /usr/local/bin/vault
+
+RUN groupadd -r kibana && useradd -r -g kibana kibana && mkdir /home/kibana && chown kibana:kibana /home/kibana
+
+COPY ./bash_standard_lib.sh /usr/local/bin/bash_standard_lib.sh
+RUN chmod +x /usr/local/bin/bash_standard_lib.sh
+
+COPY ./runbld /usr/local/bin/runbld
+RUN chmod +x /usr/local/bin/runbld
+
+USER kibana

.ci/Jenkinsfile_baseline_capture

@@ -7,18 +7,22 @@ kibanaPipeline(timeoutMinutes: 120) {
   githubCommitStatus.trackBuild(params.commit, 'kibana-ci-baseline') {
     ciStats.trackBuild {
       catchError {
-        parallel([
-          'oss-visualRegression': {
-            workers.ci(name: 'oss-visualRegression', size: 's-highmem', ramDisk: true) {
-              kibanaPipeline.functionalTestProcess('oss-visualRegression', './test/scripts/jenkins_visual_regression.sh')(1)
-            }
-          },
-          'xpack-visualRegression': {
-            workers.ci(name: 'xpack-visualRegression', size: 's-highmem', ramDisk: true) {
-              kibanaPipeline.functionalTestProcess('xpack-visualRegression', './test/scripts/jenkins_xpack_visual_regression.sh')(1)
-            }
-          },
-        ])
+        withEnv([
+          'CI_PARALLEL_PROCESS_NUMBER=1'
+        ]) {
+          parallel([
+            'oss-visualRegression': {
+              workers.ci(name: 'oss-visualRegression', size: 's-highmem', ramDisk: true) {
+                kibanaPipeline.functionalTestProcess('oss-visualRegression', './test/scripts/jenkins_visual_regression.sh')()
+              }
+            },
+            'xpack-visualRegression': {
+              workers.ci(name: 'xpack-visualRegression', size: 's-highmem', ramDisk: true) {
+                kibanaPipeline.functionalTestProcess('xpack-visualRegression', './test/scripts/jenkins_xpack_visual_regression.sh')()
+              }
+            },
+          ])
+        }
       }
 
       kibanaPipeline.sendMail()

.ci/pipeline-library/src/test/prChanges.groovy

@@ -97,4 +97,17 @@ class PrChangesTest extends KibanaBasePipelineTest {
 
     assertFalse(prChanges.areChangesSkippable())
   }
+
+  @Test
+  void 'areChangesSkippable() with plugin readme changes'() {
+    props([
+      githubPrs: [
+        getChanges: { [
+          [filename: 'src/plugins/foo/README.asciidoc'],
+        ] },
+      ],
+    ])
+
+    assertFalse(prChanges.areChangesSkippable())
+  }
 }

.ci/runbld_no_junit.yml

@@ -3,4 +3,4 @@
 profiles:
 - ".*": # Match any job
     tests:
-      junit-filename-pattern: "8d8bd494-d909-4e67-a052-7e8b5aaeb5e4" # A bogus path that should never exist
+      junit-filename-pattern: false

.eslintrc.js

@@ -132,12 +132,6 @@ module.exports = {
         'react-hooks/rules-of-hooks': 'off',
       },
     },
-    {
-      files: ['x-pack/plugins/lens/**/*.{js,mjs,ts,tsx}'],
-      rules: {
-        'react-hooks/exhaustive-deps': 'off',
-      },
-    },
     {
       files: ['x-pack/plugins/ml/**/*.{js,mjs,ts,tsx}'],
       rules: {

.github/CODEOWNERS

@@ -7,7 +7,6 @@
 /x-pack/plugins/discover_enhanced/ @elastic/kibana-app
 /x-pack/plugins/lens/ @elastic/kibana-app
 /x-pack/plugins/graph/ @elastic/kibana-app
-/src/legacy/core_plugins/kibana/public/local_application_service/ @elastic/kibana-app
 /src/plugins/dashboard/ @elastic/kibana-app
 /src/plugins/discover/ @elastic/kibana-app
 /src/plugins/input_control_vis/ @elastic/kibana-app

.gitignore

@@ -49,6 +49,8 @@ npm-debug.log*
 .tern-project
 .nyc_output
 .ci/pipeline-library/build/
+.ci/runbld
+.ci/bash_standard_lib.sh
 .gradle
 
 # apm plugin

Jenkinsfile

@@ -9,49 +9,7 @@ kibanaPipeline(timeoutMinutes: 155, checkPrChanges: true, setCommitStatus: true)
       ciStats.trackBuild {
         catchError {
           retryable.enable()
-          parallel([
-            'kibana-intake-agent': workers.intake('kibana-intake', './test/scripts/jenkins_unit.sh'),
-            'x-pack-intake-agent': workers.intake('x-pack-intake', './test/scripts/jenkins_xpack.sh'),
-            'kibana-oss-agent': workers.functional('kibana-oss-tests', { kibanaPipeline.buildOss() }, [
-              'oss-firefoxSmoke': kibanaPipeline.functionalTestProcess('kibana-firefoxSmoke', './test/scripts/jenkins_firefox_smoke.sh'),
-              'oss-ciGroup1': kibanaPipeline.ossCiGroupProcess(1),
-              'oss-ciGroup2': kibanaPipeline.ossCiGroupProcess(2),
-              'oss-ciGroup3': kibanaPipeline.ossCiGroupProcess(3),
-              'oss-ciGroup4': kibanaPipeline.ossCiGroupProcess(4),
-              'oss-ciGroup5': kibanaPipeline.ossCiGroupProcess(5),
-              'oss-ciGroup6': kibanaPipeline.ossCiGroupProcess(6),
-              'oss-ciGroup7': kibanaPipeline.ossCiGroupProcess(7),
-              'oss-ciGroup8': kibanaPipeline.ossCiGroupProcess(8),
-              'oss-ciGroup9': kibanaPipeline.ossCiGroupProcess(9),
-              'oss-ciGroup10': kibanaPipeline.ossCiGroupProcess(10),
-              'oss-ciGroup11': kibanaPipeline.ossCiGroupProcess(11),
-              'oss-ciGroup12': kibanaPipeline.ossCiGroupProcess(12),
-              'oss-accessibility': kibanaPipeline.functionalTestProcess('kibana-accessibility', './test/scripts/jenkins_accessibility.sh'),
-              // 'oss-visualRegression': kibanaPipeline.functionalTestProcess('visualRegression', './test/scripts/jenkins_visual_regression.sh'),
-            ]),
-            'kibana-xpack-agent': workers.functional('kibana-xpack-tests', { kibanaPipeline.buildXpack() }, [
-              'xpack-firefoxSmoke': kibanaPipeline.functionalTestProcess('xpack-firefoxSmoke', './test/scripts/jenkins_xpack_firefox_smoke.sh'),
-              'xpack-ciGroup1': kibanaPipeline.xpackCiGroupProcess(1),
-              'xpack-ciGroup2': kibanaPipeline.xpackCiGroupProcess(2),
-              'xpack-ciGroup3': kibanaPipeline.xpackCiGroupProcess(3),
-              'xpack-ciGroup4': kibanaPipeline.xpackCiGroupProcess(4),
-              'xpack-ciGroup5': kibanaPipeline.xpackCiGroupProcess(5),
-              'xpack-ciGroup6': kibanaPipeline.xpackCiGroupProcess(6),
-              'xpack-ciGroup7': kibanaPipeline.xpackCiGroupProcess(7),
-              'xpack-ciGroup8': kibanaPipeline.xpackCiGroupProcess(8),
-              'xpack-ciGroup9': kibanaPipeline.xpackCiGroupProcess(9),
-              'xpack-ciGroup10': kibanaPipeline.xpackCiGroupProcess(10),
-              'xpack-accessibility': kibanaPipeline.functionalTestProcess('xpack-accessibility', './test/scripts/jenkins_xpack_accessibility.sh'),
-              'xpack-savedObjectsFieldMetrics': kibanaPipeline.functionalTestProcess('xpack-savedObjectsFieldMetrics', './test/scripts/jenkins_xpack_saved_objects_field_metrics.sh'),
-              'xpack-securitySolutionCypress': { processNumber ->
-                whenChanged(['x-pack/plugins/security_solution/', 'x-pack/test/security_solution_cypress/', 'x-pack/plugins/triggers_actions_ui/public/application/sections/action_connector_form/', 'x-pack/plugins/triggers_actions_ui/public/application/context/actions_connectors_context.tsx']) {
-                  kibanaPipeline.functionalTestProcess('xpack-securitySolutionCypress', './test/scripts/jenkins_security_solution_cypress.sh')(processNumber)
-                }
-              },
-
-              // 'xpack-visualRegression': kibanaPipeline.functionalTestProcess('xpack-visualRegression', './test/scripts/jenkins_xpack_visual_regression.sh'),
-            ]),
-          ])
+          kibanaPipeline.allCiTasks()
         }
       }
     }

docs/developer/architecture/code-exploration.asciidoc

@@ -58,9 +58,9 @@ The Charts plugin is a way to create easier integration of shared colors, themes
 WARNING: Missing README.
 
 
-- {kib-repo}blob/{branch}/src/plugins/dashboard[dashboard]
+- {kib-repo}blob/{branch}/src/plugins/dashboard/README.md[dashboard]
 
-WARNING: Missing README.
+Contains the dashboard application.
 
 
 - {kib-repo}blob/{branch}/src/plugins/data/README.md[data]
@@ -76,9 +76,9 @@ Routing will be handled by the id of the dev tool - your dev tool will be mounte
 This API doesn't support angular, for registering angular dev tools, bootstrap a local module on mount into the given HTML element.
 
 
-- {kib-repo}blob/{branch}/src/plugins/discover[discover]
+- {kib-repo}blob/{branch}/src/plugins/discover/README.md[discover]
 
-WARNING: Missing README.
+Contains the Discover application and the saved search embeddable.
 
 
 - {kib-repo}blob/{branch}/src/plugins/embeddable/README.md[embeddable]
@@ -109,9 +109,9 @@ Moves the legacy ui/registry/feature_catalogue module for registering "features"
 WARNING: Missing README.
 
 
-- {kib-repo}blob/{branch}/src/plugins/input_control_vis[inputControlVis]
+- {kib-repo}blob/{branch}/src/plugins/input_control_vis/README.md[inputControlVis]
 
-WARNING: Missing README.
+Contains the input control visualization allowing to place custom filter controls on a dashboard.
 
 
 - {kib-repo}blob/{branch}/src/plugins/inspector/README.md[inspector]
@@ -206,9 +206,10 @@ This plugin adds the Advanced Settings section for the Usage Data collection (ak
 WARNING: Missing README.
 
 
-- {kib-repo}blob/{branch}/src/plugins/timelion[timelion]
+- {kib-repo}blob/{branch}/src/plugins/timelion/README.md[timelion]
 
-WARNING: Missing README.
+Contains the deprecated timelion application. For the timelion visualization,
+which also contains the timelion APIs and backend, look at the vis_type_timelion plugin.
 
 
 - {kib-repo}blob/{branch}/src/plugins/ui_actions/README.md[uiActions]
@@ -222,59 +223,63 @@ Usage Collection allows collecting usage data for other services to consume (tel
 To integrate with the telemetry services for usage collection of your feature, there are 2 steps:
 
 
-- {kib-repo}blob/{branch}/src/plugins/vis_type_markdown[visTypeMarkdown]
+- {kib-repo}blob/{branch}/src/plugins/vis_type_markdown/README.md[visTypeMarkdown]
 
-WARNING: Missing README.
+The markdown visualization that can be used to place text panels on dashboards.
 
 
-- {kib-repo}blob/{branch}/src/plugins/vis_type_metric[visTypeMetric]
+- {kib-repo}blob/{branch}/src/plugins/vis_type_metric/README.md[visTypeMetric]
 
-WARNING: Missing README.
+Contains the metric visualization.
 
 
-- {kib-repo}blob/{branch}/src/plugins/vis_type_table[visTypeTable]
+- {kib-repo}blob/{branch}/src/plugins/vis_type_table/README.md[visTypeTable]
 
-WARNING: Missing README.
+Contains the data table visualization, that allows presenting data in a simple table format.
 
 
-- {kib-repo}blob/{branch}/src/plugins/vis_type_tagcloud[visTypeTagcloud]
+- {kib-repo}blob/{branch}/src/plugins/vis_type_tagcloud/README.md[visTypeTagcloud]
 
-WARNING: Missing README.
+Contains the tagcloud visualization.
 
 
 - {kib-repo}blob/{branch}/src/plugins/vis_type_timelion/README.md[visTypeTimelion]
 
-If your grammar was changed in public/chain.peg you need to re-generate the static parser. You could use a grunt task:
+Contains the timelion visualization and the timelion backend.
 
 
-- {kib-repo}blob/{branch}/src/plugins/vis_type_timeseries[visTypeTimeseries]
+- {kib-repo}blob/{branch}/src/plugins/vis_type_timeseries/README.md[visTypeTimeseries]
 
-WARNING: Missing README.
+Contains everything around TSVB (the editor, visualizatin implementations and backends).
 
 
-- {kib-repo}blob/{branch}/src/plugins/vis_type_vega[visTypeVega]
+- {kib-repo}blob/{branch}/src/plugins/vis_type_vega/README.md[visTypeVega]
 
-WARNING: Missing README.
+Contains the Vega visualization.
 
 
-- {kib-repo}blob/{branch}/src/plugins/vis_type_vislib[visTypeVislib]
+- {kib-repo}blob/{branch}/src/plugins/vis_type_vislib/README.md[visTypeVislib]
 
-WARNING: Missing README.
+Contains the vislib visualizations. These are the classical area/line/bar, pie, gauge/goal and
+heatmap charts.
 
 
-- {kib-repo}blob/{branch}/src/plugins/vis_type_xy[visTypeXy]
+- {kib-repo}blob/{branch}/src/plugins/vis_type_xy/README.md[visTypeXy]
 
-WARNING: Missing README.
+Contains the new xy-axis chart using the elastic-charts library, which will eventually
+replace the vislib xy-axis (bar, area, line) charts.
 
 
-- {kib-repo}blob/{branch}/src/plugins/visualizations[visualizations]
+- {kib-repo}blob/{branch}/src/plugins/visualizations/README.md[visualizations]
 
-WARNING: Missing README.
+Contains most of the visualization infrastructure, e.g. the visualization type registry or the
+visualization embeddable.
 
 
-- {kib-repo}blob/{branch}/src/plugins/visualize[visualize]
+- {kib-repo}blob/{branch}/src/plugins/visualize/README.md[visualize]
 
-WARNING: Missing README.
+Contains the visualize application which includes the listing page and the app frame,
+which will load the visualization's editor.
 
 
 [discrete]
@@ -345,19 +350,22 @@ You can run a local cluster and simulate a remote cluster within a single Kibana
 
 - {kib-repo}blob/{branch}/x-pack/plugins/dashboard_enhanced/README.md[dashboardEnhanced]
 
-- {kib-repo}blob/{branch}/x-pack/plugins/dashboard_mode[dashboardMode]
+Contains the enhancements to the OSS dashboard app.
 
-WARNING: Missing README.
+
+- {kib-repo}blob/{branch}/x-pack/plugins/dashboard_mode/README.md[dashboardMode]
+
+The deprecated dashboard only mode.
 
 
 - {kib-repo}blob/{branch}/x-pack/plugins/data_enhanced[dataEnhanced]
 
 WARNING: Missing README.
 
 
-- {kib-repo}blob/{branch}/x-pack/plugins/discover_enhanced[discoverEnhanced]
+- {kib-repo}blob/{branch}/x-pack/plugins/discover_enhanced/README.md[discoverEnhanced]
 
-WARNING: Missing README.
+Contains the enhancements to the OSS discover app.
 
 
 - {kib-repo}blob/{branch}/x-pack/plugins/embeddable_enhanced[embeddableEnhanced]

docs/development/plugins/kibana_utils/public/state_sync/kibana-plugin-plugins-kibana_utils-public-state_sync.isyncstateref.md

@@ -8,7 +8,7 @@
 <b>Signature:</b>
 
 ```typescript
-export interface ISyncStateRef<stateStorage extends IStateStorage = IStateStorage> 
+export interface ISyncStateRef<StateStorage extends IStateStorage = IStateStorage> 
 ```
 
 ## Properties