Skip to content

Commit 0f581df

Browse files
committed
Changed lens and visualize to use navigateToApp when returning to a non-dashboard originating app
1 parent e481dc1 commit 0f581df

File tree

2 files changed

+3
-8
lines changed
  • src/plugins/visualize/public/application/editor
  • x-pack/plugins/lens/public/app_plugin

2 files changed

+3
-8
lines changed

src/plugins/visualize/public/application/editor/editor.js

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,7 @@ function VisualizeAppController($scope, $route, $injector, $timeout, kbnUrlState
6969
data: { query: queryService, indexPatterns },
7070
toastNotifications,
7171
chrome,
72-
core: { docLinks, fatalErrors, uiSettings },
72+
core: { docLinks, fatalErrors, uiSettings, application },
7373
I18nContext,
7474
setActiveUrl,
7575
visualizations,
@@ -684,8 +684,7 @@ function VisualizeAppController($scope, $route, $injector, $timeout, kbnUrlState
684684
embeddableType: VISUALIZE_EMBEDDABLE_TYPE,
685685
});
686686
} else {
687-
const href = chrome.navLinks.get(lastAppType).url;
688-
window.location.href = href;
687+
application.navigateToApp(lastAppType);
689688
}
690689
} else if (savedVis.id === $route.current.params.id) {
691690
chrome.docTitle.change(savedVis.lastSavedTitle);

x-pack/plugins/lens/public/app_plugin/mounter.tsx

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -70,11 +70,7 @@ export async function mountApp(
7070
embeddableType: LENS_EMBEDDABLE_TYPE,
7171
});
7272
} else {
73-
const originatingAppLink = coreStart.chrome.navLinks.get(originatingApp);
74-
if (!originatingAppLink || !originatingAppLink.url) {
75-
throw new Error('Cannot get originating app url');
76-
}
77-
window.location.href = originatingAppLink.url;
73+
coreStart.application.navigateToApp(originatingApp);
7874
}
7975
}
8076
};

0 commit comments

Comments
 (0)