Skip to content

Commit 066865d

Browse files
add todos
1 parent 6e0e168 commit 066865d

File tree

5 files changed

+5
-1
lines changed

5 files changed

+5
-1
lines changed

x-pack/legacy/plugins/maps/public/layers/fields/ems_region_field.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@
88
import { AbstractField } from './field';
99
import { TooltipProperty } from '../tooltips/tooltip_property';
1010

11+
//todo: rename to ESMFileField
1112
export class EMSRegionLayerField extends AbstractField {
1213
static type = 'EMS_REGION_LAYER';
1314

x-pack/legacy/plugins/maps/public/layers/fields/field.js

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,8 @@
77

88
export class AbstractField {
99

10+
//todo consider removing
11+
//double check if we're actually using this consistently
1012
static FIELD_TYPE = {
1113
STRING: 'string',
1214
NUMBER: 'number',

x-pack/legacy/plugins/maps/public/layers/fields/kibana_region_field.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@
77

88
import { AbstractField } from './field';
99

10+
//todo: need to be implemented
1011
export class KibanaRegionField extends AbstractField {
1112

1213
static type = 'KIBANA_REGION';

x-pack/legacy/plugins/maps/public/layers/sources/es_agg_source.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@ const COUNT_PROP_NAME = 'doc_count';
1616

1717
const AGG_DELIMITER = '_of_';
1818

19+
//todo: extract in separate PR
1920
export class AbstractESAggSource extends AbstractESSource {
2021

2122
static COUNT_PROP_LABEL = COUNT_PROP_LABEL;

x-pack/legacy/plugins/maps/public/layers/styles/vector/vector_style.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,6 @@ export class VectorStyle extends AbstractStyle {
3434

3535
static type = 'VECTOR';
3636

37-
3837
static createDescriptor(properties = {}) {
3938
return {
4039
type: VectorStyle.type,

0 commit comments

Comments
 (0)