[Lens] Remove client-side reference to server source code (#51763) (#51825)

Author: chrisdavies

x-pack/legacy/plugins/lens/common/constants.ts

@@ -5,7 +5,7 @@
  */
 
 export const PLUGIN_ID = 'lens';
-
+export const NOT_INTERNATIONALIZED_PRODUCT_NAME = 'Lens Visualizations';
 export const BASE_APP_URL = '/app/kibana';
 export const BASE_API_URL = '/api/lens';
 

x-pack/legacy/plugins/lens/index.ts

@@ -9,11 +9,9 @@ import { resolve } from 'path';
 import { LegacyPluginInitializer } from 'src/legacy/types';
 import KbnServer, { Server } from 'src/legacy/server/kbn_server';
 import mappings from './mappings.json';
-import { PLUGIN_ID, getEditPath } from './common';
+import { PLUGIN_ID, getEditPath, NOT_INTERNATIONALIZED_PRODUCT_NAME } from './common';
 import { lensServerPlugin } from './server';
 
-export const NOT_INTERNATIONALIZED_PRODUCT_NAME = 'Lens Visualizations';
-
 export const lens: LegacyPluginInitializer = kibana => {
   return new kibana.Plugin({
     id: PLUGIN_ID,

x-pack/legacy/plugins/lens/public/app_plugin/plugin.tsx

@@ -38,7 +38,7 @@ import {
   stopReportManager,
   trackUiEvent,
 } from '../lens_ui_telemetry';
-import { NOT_INTERNATIONALIZED_PRODUCT_NAME } from '../../index';
+import { NOT_INTERNATIONALIZED_PRODUCT_NAME } from '../../common';
 import { KibanaLegacySetup } from '../../../../../../src/plugins/kibana_legacy/public';
 import { EditorFrameStart } from '../types';
 
@@ -50,6 +50,7 @@ export interface LensPluginStartDependencies {
   data: DataPublicPluginStart;
   dataShim: DataStart;
 }
+
 export class AppPlugin {
   private startDependencies: {
     data: DataPublicPluginStart;