Show toast when an error ocurrs and add tests

Author: sabarasaba

x-pack/plugins/upgrade_assistant/__jest__/client_integration/helpers/http_requests.ts

@@ -69,6 +69,16 @@ const registerHttpRequestMockHelpers = (server: SinonFakeServer) => {
     ]);
   };
 
+  const setDeleteLogsCacheResponse = (response?: string, error?: ResponseError) => {
+    const status = error ? error.statusCode || 400 : 200;
+    const body = error ? error : response;
+    server.respondWith('DELETE', `${API_BASE_PATH}/deprecation_logging/cache`, [
+      status,
+      { 'Content-Type': 'application/json' },
+      JSON.stringify(body),
+    ]);
+  };
+
   const setUpdateDeprecationLoggingResponse = (
     response?: DeprecationLoggingStatus,
     error?: ResponseError
@@ -169,6 +179,7 @@ const registerHttpRequestMockHelpers = (server: SinonFakeServer) => {
     setDeleteMlSnapshotResponse,
     setUpgradeMlSnapshotStatusResponse,
     setLoadDeprecationLogsCountResponse,
+    setDeleteLogsCacheResponse,
     setStartReindexingResponse,
     setReindexStatusResponse,
     setLoadMlUpgradeModeResponse,

x-pack/plugins/upgrade_assistant/__jest__/client_integration/overview/fix_logs_step/fix_logs_step.test.tsx

@@ -248,6 +248,7 @@ describe('Overview - Fix deprecation logs step', () => {
   describe('Step 3 - Resolve log issues', () => {
     beforeEach(async () => {
       httpRequestsMockHelpers.setLoadDeprecationLoggingResponse(getLoggingResponse(true));
+      httpRequestsMockHelpers.setDeleteLogsCacheResponse('ok');
     });
 
     test('With deprecation warnings', async () => {
@@ -337,6 +338,47 @@ describe('Overview - Fix deprecation logs step', () => {
       expect(exists('noWarningsCallout')).toBe(true);
     });
 
+    test('Shows a toast if deleting cache fails', async () => {
+      const error = {
+        statusCode: 500,
+        error: 'Internal server error',
+        message: 'Internal server error',
+      };
+
+      httpRequestsMockHelpers.setDeleteLogsCacheResponse(undefined, error);
+      httpRequestsMockHelpers.setLoadDeprecationLogsCountResponse({ count: 10 });
+
+      const addDanger = jest.fn();
+      await act(async () => {
+        testBed = await setupOverviewPage({
+          services: {
+            core: {
+              notifications: {
+                toasts: {
+                  addDanger,
+                },
+              },
+            },
+          },
+        });
+      });
+
+      const { exists, actions, component } = testBed;
+
+      component.update();
+
+      httpRequestsMockHelpers.setLoadDeprecationLogsCountResponse({ count: 0 });
+
+      await actions.clickResetButton();
+
+      // The toast should always be shown if the delete logs cache fails.
+      expect(addDanger).toHaveBeenCalled();
+      // Even though a stub for the API call getting the count was set to return 0,
+      // given that the delete logs cache API call will fail the callout remains in
+      // warning state.
+      expect(exists('hasWarningsCallout')).toBe(true);
+    });
+
     describe('Poll for logs count', () => {
       beforeEach(async () => {
         jest.useFakeTimers();

x-pack/plugins/upgrade_assistant/public/application/components/overview/fix_logs_step/deprecations_count_checkpoint/deprecations_count_checkpoint.tsx

@@ -46,6 +46,9 @@ const i18nTexts = {
       defaultMessage: 'Reset counter',
     }
   ),
+  errorToastTitle: i18n.translate('xpack.upgradeAssistant.overview.verifyChanges.errorToastTitle', {
+    defaultMessage: 'Could not clear deprecation logs cache',
+  }),
 };
 
 interface Props {
@@ -60,7 +63,10 @@ export const DeprecationsCountCheckpoint: FunctionComponent<Props> = ({
   setHasNoDeprecationLogs,
 }) => {
   const {
-    services: { api },
+    services: {
+      api,
+      core: { notifications },
+    },
   } = useAppContext();
   const { data, error, isLoading, resendRequest, isInitialRequest } =
     api.getDeprecationLogsCount(checkpoint);
@@ -72,9 +78,18 @@ export const DeprecationsCountCheckpoint: FunctionComponent<Props> = ({
   const calloutTestId = hasLogs ? 'hasWarningsCallout' : 'noWarningsCallout';
 
   const onResetClick = async () => {
+    const { error: deleteLogsCacheError } = await api.deleteDeprecationLogsCache();
+
+    if (deleteLogsCacheError) {
+      notifications.toasts.addDanger({
+        title: i18nTexts.errorToastTitle,
+        text: deleteLogsCacheError.message.toString(),
+      });
+      return;
+    }
+
     const now = moment().toISOString();
     uiMetricService.trackUiMetric(METRIC_TYPE.CLICK, UIM_RESET_LOGS_COUNTER_CLICK);
-    api.deleteDeprecationLogsCache();
     setCheckpoint(now);
   };
 

x-pack/plugins/upgrade_assistant/public/application/lib/api.ts

@@ -96,13 +96,11 @@ export class ApiService {
     });
   }
 
-  public async deleteDeprecationLogsCache() {
-    const result = await this.sendRequest({
-      path: `${API_BASE_PATH}/deprecation_logging/deprecation_cache`,
+  public deleteDeprecationLogsCache() {
+    return this.sendRequest({
+      path: `${API_BASE_PATH}/deprecation_logging/cache`,
       method: 'delete',
     });
-
-    return result;
   }
 
   public async updateIndexSettings(indexName: string, settings: string[]) {

x-pack/plugins/upgrade_assistant/server/routes/deprecation_logging.test.ts

@@ -176,4 +176,42 @@ describe('deprecation logging API', () => {
       ).rejects.toThrow('scary error!');
     });
   });
+
+  describe('DELETE /api/upgrade_assistant/deprecation_logging/cache', () => {
+    it('returns ok if if the cache was deleted', async () => {
+      (
+        routeHandlerContextMock.core.elasticsearch.client.asCurrentUser.transport
+          .request as jest.Mock
+      ).mockResolvedValue({
+        body: 'ok',
+      });
+
+      const resp = await routeDependencies.router.getHandler({
+        method: 'delete',
+        pathPattern: '/api/upgrade_assistant/deprecation_logging/cache',
+      })(routeHandlerContextMock, createRequestMock(), kibanaResponseFactory);
+
+      expect(resp.status).toEqual(200);
+      expect(
+        routeHandlerContextMock.core.elasticsearch.client.asCurrentUser.transport.request
+      ).toHaveBeenCalledWith({
+        method: 'DELETE',
+        path: '/_logging/deprecation_cache',
+      });
+      expect(resp.payload).toEqual('ok');
+    });
+
+    it('returns an error if it throws', async () => {
+      (
+        routeHandlerContextMock.core.elasticsearch.client.asCurrentUser.transport
+          .request as jest.Mock
+      ).mockRejectedValue(new Error('scary error!'));
+      await expect(
+        routeDependencies.router.getHandler({
+          method: 'delete',
+          pathPattern: '/api/upgrade_assistant/deprecation_logging/cache',
+        })(routeHandlerContextMock, createRequestMock(), kibanaResponseFactory)
+      ).rejects.toThrow('scary error!');
+    });
+  });
 });

x-pack/plugins/upgrade_assistant/server/routes/deprecation_logging.ts

@@ -127,7 +127,7 @@ export function registerDeprecationLoggingRoutes({
 
   router.delete(
     {
-      path: `${API_BASE_PATH}/deprecation_logging/deprecation_cache`,
+      path: `${API_BASE_PATH}/deprecation_logging/cache`,
       validate: false,
     },
     versionCheckHandlerWrapper(