Skip to content

Commit 0090a06

Browse files
committed
emitting done when no data inside visualization container
1 parent 2888c75 commit 0090a06

File tree

5 files changed

+12
-5
lines changed

5 files changed

+12
-5
lines changed

src/plugins/vis_type_markdown/public/markdown_renderer.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ export const markdownVisRenderer: ExpressionRenderDefinition<MarkdownVisRenderVa
3636
});
3737

3838
render(
39-
<VisualizationContainer className="markdownVis">
39+
<VisualizationContainer className="markdownVis" handlers={handlers}>
4040
<MarkdownVisComponent {...visParams} renderComplete={handlers.done} />
4141
</VisualizationContainer>,
4242
domNode

src/plugins/vis_type_metric/public/metric_vis_renderer.tsx

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,11 @@ export const metricVisRenderer: () => ExpressionRenderDefinition<MetricVisRender
3636
});
3737

3838
render(
39-
<VisualizationContainer className="mtrVis" showNoResult={!visData.rows?.length}>
39+
<VisualizationContainer
40+
className="mtrVis"
41+
showNoResult={!visData.rows?.length}
42+
handlers={handlers}
43+
>
4044
<MetricVisComponent
4145
visData={visData}
4246
visParams={visConfig}

src/plugins/vis_type_tagcloud/public/tag_cloud_vis_renderer.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@ export const getTagCloudVisRenderer: (
3939
});
4040

4141
render(
42-
<VisualizationContainer>
42+
<VisualizationContainer handlers={handlers}>
4343
<TagCloudChart
4444
{...config}
4545
colors={colors}

src/plugins/vis_type_timelion/public/timelion_vis_renderer.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ export const getTimelionVisRenderer: (
4949
}
5050

5151
render(
52-
<VisualizationContainer showNoResult={showNoResult}>
52+
<VisualizationContainer handlers={handlers} showNoResult={showNoResult}>
5353
<KibanaContextProvider services={{ ...deps }}>
5454
<TimelionVisComponent
5555
interval={visParams.interval}

src/plugins/visualizations/public/components/visualization_container.tsx

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,16 +21,19 @@ import React, { ReactNode, Suspense } from 'react';
2121
import { EuiLoadingChart } from '@elastic/eui';
2222
import classNames from 'classnames';
2323
import { VisualizationNoResults } from './visualization_noresults';
24+
import { IInterpreterRenderHandlers } from '../../../expressions/common';
2425

2526
interface VisualizationContainerProps {
2627
className?: string;
2728
children: ReactNode;
29+
handlers: IInterpreterRenderHandlers;
2830
showNoResult?: boolean;
2931
}
3032

3133
export const VisualizationContainer = ({
3234
className,
3335
children,
36+
handlers,
3437
showNoResult = false,
3538
}: VisualizationContainerProps) => {
3639
const classes = classNames('visualization', className);
@@ -44,7 +47,7 @@ export const VisualizationContainer = ({
4447
return (
4548
<div className={classes}>
4649
<Suspense fallback={fallBack}>
47-
{showNoResult ? <VisualizationNoResults /> : children}
50+
{showNoResult ? <VisualizationNoResults onInit={() => handlers.done()} /> : children}
4851
</Suspense>
4952
</div>
5053
);

0 commit comments

Comments
 (0)