Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add system test for Zeek FTP, OCSP #676

Merged
merged 2 commits into from
Feb 9, 2021

Conversation

andrewkroh
Copy link
Member

What does this PR do?

Add system test for Zeek FTP

This adds a system test for the Zeek FTP data stream.

There were missing fields for

  • network.protocol
  • network.transport

Add system test for Zeek OCSP

This adds a system test for the Zeek OCSP data stream.

One field, zeek.ocsp.revoke.date was incorrectly named in fields.yml.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.

Related issues

This adds a system test for the Zeek FTP data stream.

There were missing fields for
- network.protocol
- network.transport
This adds a system test for the Zeek OCSP data stream.

One field, zeek.ocsp.revoke.date was incorrectly named in fields.yml.
@elasticmachine
Copy link

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@andrewkroh
Copy link
Member Author

andrewkroh commented Feb 9, 2021

For future reference: The sample OSCP logs were generated from https://packetlife.net/captures/protocol/ocsp/ using

docker run --rm -v /Users/akroh/Downloads/pcap:/pcap:rw blacktop/zeek -r OCSP-Good.cap local LogAscii::use_json=T "policy/files/x509/log-ocsp.zeek"

docker run --rm -v /Users/akroh/Downloads/pcap:/pcap:rw blacktop/zeek -r OCSP-Revoked.cap local LogAscii::use_json=T "policy/files/x509/log-ocsp.zeek"

@elasticmachine
Copy link

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Pull request #676 opened

  • Start Time: 2021-02-09T01:54:03.435+0000

  • Duration: 28 min 18 sec

  • Commit: db18129

Test stats 🧪

Test Results
Failed 0
Passed 119
Skipped 0
Total 119

Trends 🧪

Image of Build Times

Image of Tests

@andrewkroh andrewkroh requested a review from leehinman February 9, 2021 14:41
@andrewkroh andrewkroh merged commit 39b72df into elastic:master Feb 9, 2021
eyalkraft pushed a commit to build-security/integrations that referenced this pull request Mar 30, 2022
* Add system test for Zeek FTP

This adds a system test for the Zeek FTP data stream.

There were missing fields for
- network.protocol
- network.transport

* Add system test for Zeek OCSP

This adds a system test for the Zeek OCSP data stream.

One field, zeek.ocsp.revoke.date was incorrectly named in fields.yml.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants