Skip to content

Conversation

@aleksmaus
Copy link
Contributor

What does this PR do?

Adds ECS dependency in order to fix ECS fields resolution in the package.
Addressed #3926

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Related issues

Screenshots

Before the fix, the ECS field in the package is not resolved:
Screen Shot 2022-08-16 at 12 03 11 PM

After the fix, the ECS field in the package is resolved:
Screen Shot 2022-08-16 at 12 03 28 PM

@aleksmaus aleksmaus added bug Something isn't working, use only for issues Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team labels Aug 16, 2022
@aleksmaus aleksmaus requested a review from a team as a code owner August 16, 2022 16:13
@elasticmachine
Copy link

Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane)

@elasticmachine
Copy link

elasticmachine commented Aug 16, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-08-16T16:16:01.335+0000

  • Duration: 15 min 39 sec

Test stats 🧪

Test Results
Failed 0
Passed 32
Skipped 0
Total 32

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (0/0) 💚
Files 100.0% (0/0) 💚 2.825
Classes 100.0% (0/0) 💚 2.825
Methods 33.333% (22/66) 👎 -56.001
Lines 100.0% (0/0) 💚 9.082
Conditionals 100.0% (0/0) 💚

@aleksmaus aleksmaus merged commit 01bc513 into elastic:main Aug 18, 2022
@aleksmaus aleksmaus deleted the fix/ecs_resolution branch August 18, 2022 18:57
@kpollich
Copy link
Member

Are we targeting a 1.3.5 release for the elastic_agent integration containing these changes? I'd like to bundle it with the next 8.4 patch release of Kibana and close out elastic/kibana#138257 if possible.

@aleksmaus
Copy link
Contributor Author

aleksmaus commented Aug 26, 2022

The packages are released at whenever, usually tied to particular release by the version constraints in the manifest. This one is still in the snapshot and was not pushed to production. Can promote to production now, so 8.4 release can immediately see it.

@joshdover
Copy link
Contributor

@kpollich should we bump the version in https://github.com/elastic/kibana/blob/main/fleet_packages.json for the next patch release?

@kpollich
Copy link
Member

I would like to update fleet_packages.json to include elastic-agent-1.3.5, but it appears to only exist on the production registry, not the snapshot registry: https://epr-snapshot.elastic.co/search?package=elastic_agent&experimental=true

Since the bundling process relies on the version existing in snapshot for now, we can't update it.

@aleksmaus
Copy link
Contributor Author

@joshdover @kpollich should bump up the version and release into snapshot 1.3.6?
was not aware of details of bundling process

@kpollich
Copy link
Member

@aleksmaus Yes that sounds like a good path forward, no worries at all

@aleksmaus aleksmaus mentioned this pull request Aug 29, 2022
4 tasks
@joshdover
Copy link
Contributor

@kpollich I think we just need to redeploy snapshot. I can trigger this now. I saw this problem on staging earlier today and redeploying fixed the problem.

@joshdover
Copy link
Contributor

Looks like it was deployed already: https://epr-snapshot.elastic.co/search?package=elastic_agent

@aleksmaus
Copy link
Contributor Author

Looks like it was deployed already: https://epr-snapshot.elastic.co/search?package=elastic_agent

Thank you! Will close that PR

@kpollich
Copy link
Member

Bumped bundled version of elastic agent in elastic/kibana#139650

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working, use only for issues Integration:elastic_agent Elastic Agent Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Fleet] ECS fields in packages are not included in index.query.default_field setting

7 participants