New httpcheck OTel input package #15785
Conversation
jsoriano
force-pushed
the
new-httpcheck-package
branch
from
06ab133 to
c12feee
Compare
andrewkroh
added
New Integration
packages/httpcheck/sample_event.json
Outdated
| "http.url": "http://svc-web:80" | ||
| }, | ||
| "data_stream": { | ||
| "dataset": "httpcheck.httpcheckreceiver.otel", |
There was a problem hiding this comment.
Shouldn't it be httpcheckreceiver.otel ?
There was a problem hiding this comment.
In a real case it will indeed be httpcheckreceiver.otel.
Here this document is obtained with elastic-package test system, what is configuring the dataset as <package name>.<policy template name> for legacy reasons.
I have created a follow up issue about this, I think we should fix this discrepancy at some point: elastic/elastic-package#3036
| @@ -0,0 +1,3 @@ | |||
| vars: | |||
| endpoints: | |||
| - https://epr.elastic.co | |||
There was a problem hiding this comment.
The test for input package is going to be if the policy is correctly formed ?
Any data related check we plan to add ?
There was a problem hiding this comment.
The test for input package is going to be if the policy is correctly formed ?
This kind of test is available also for integration packages, is not specific to input packages.
Any data related check we plan to add ?
System tests are the closest thing to a data related check that we have at the moment.
There was a problem hiding this comment.
Just to be clear, policy tests are not intended to collect any data, they only create a policy with some given variables and check that the generated agent policy is the expected one.
There was a problem hiding this comment.
Should we consider them as a good to have for input packages.
We usually don't have these in regular integration packages. @jsoriano
There was a problem hiding this comment.
Yeah, they could be used more broadly.
They aren't more used now probably because they were introduced not so long ago and we haven't promoted them a lot.
| connectors: | ||
| forward: {} | ||
| exporters: | ||
| elasticsearch/componentid-0: |
There was a problem hiding this comment.
What are these componentid-0 ? Fetched from epr ?
There was a problem hiding this comment.
Fleet generates this configuration with randomized component ids. Here elastic-package is replacing the random part with predictable strings so they can be compared in tests.
💔 Build Failed
Failed CI StepsHistory
cc @jsoriano |
mrodm
left a comment
mrodm
left a comment
There was a problem hiding this comment.
LGTM!
This package would require a new package-spec and elastic-package release to run tests successfully.
|
Also, shall we make the package name as httpcheck_otel ? For us to easily relate it to OTEL |
Not sure, I don't think there is going to be other |
6 participants
Proposed commit message
New OTel input package for the HTTP Check Receiver.
Checklist
changelog.ymlfile.Author's Checklist
How to test this PR locally
Related issues
Screenshots