Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fleet Server] Support configurable file upload parameters #3515

Open
michel-laterman opened this issue May 2, 2024 · 3 comments
Open

[Fleet Server] Support configurable file upload parameters #3515

michel-laterman opened this issue May 2, 2024 · 3 comments
Labels
Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team

Comments

@michel-laterman
Copy link
Contributor

File upload endpoints have hard coded configuration options:
https://github.com/elastic/fleet-server/blob/main/internal/pkg/api/handleUpload.go#L33-L34

These options should be configurable through fleet-server's policy (max file size, time limit).

Note the max file size limit is currently shared between upload/download endpoints, we will want to split these into two options

@michel-laterman michel-laterman added the Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team label May 2, 2024
@nimarezainia
Copy link

@ycombinator @cmacknz this probably needs a technical discussion, I am wondering where this UI should be exposed? If anything I believe it should be on the Fleet Server config (settings tab). and not the Fleet server policy (as that is another agent policy).

@cmacknz
Copy link
Member

cmacknz commented May 14, 2024

Yeah the settings tab makes more sense than the Fleet server policy, that is where similar things live.

@cmacknz
Copy link
Member

cmacknz commented May 17, 2024

The reason we filed this is because we observed users with diagnostics upload timeouts, but this may actually have been because of the bug above where diagnostics requests were limited to 3 minutes.

@nimarezainia nimarezainia changed the title add file manipulation config options [Fleet Server] Support configurable file upload parameters Jun 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team
Projects
None yet
Development

No branches or pull requests

4 participants