From 89c214f354cb4c8f98201eac15f0ea6bfca4da0c Mon Sep 17 00:00:00 2001 From: Lene Gadewoll Date: Wed, 5 Nov 2025 10:58:21 +0100 Subject: [PATCH 1/2] refactor: remove pointer-events - prevent potential test issues when the button is not clickable while the button is transitioning --- .../datagrid/body/header/data_grid_header_cell.styles.ts | 1 - 1 file changed, 1 deletion(-) diff --git a/packages/eui/src/components/datagrid/body/header/data_grid_header_cell.styles.ts b/packages/eui/src/components/datagrid/body/header/data_grid_header_cell.styles.ts index babed659ab1..6e34558d1ca 100644 --- a/packages/eui/src/components/datagrid/body/header/data_grid_header_cell.styles.ts +++ b/packages/eui/src/components/datagrid/body/header/data_grid_header_cell.styles.ts @@ -33,7 +33,6 @@ export const euiDataGridHeaderCellStyles = (euiThemeContext: UseEuiTheme) => { ${logicalCSS('margin-left', margin)} transform: translateX(${translateX}) scale(0.01); opacity: 0; - pointer-events: none; } `; From 6f1253b257340843944365ca3de05da23268f0bf Mon Sep 17 00:00:00 2001 From: Lene Gadewoll Date: Wed, 5 Nov 2025 11:03:04 +0100 Subject: [PATCH 2/2] test: increase wait before clicking action button - transition changed, we need to give it more time to ensure the button is available --- .../datagrid/body/header/draggable_columns.spec.tsx | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/packages/eui/src/components/datagrid/body/header/draggable_columns.spec.tsx b/packages/eui/src/components/datagrid/body/header/draggable_columns.spec.tsx index a8ad5d81e55..6f2495200ac 100644 --- a/packages/eui/src/components/datagrid/body/header/draggable_columns.spec.tsx +++ b/packages/eui/src/components/datagrid/body/header/draggable_columns.spec.tsx @@ -14,6 +14,8 @@ import React, { useState } from 'react'; import { EuiDataGrid, EuiDataGridProps } from '../../index'; import { EuiModal, EuiModalBody } from '../../../modal'; +const WAIT_FOR_TRANSITION = 250; + describe('draggable columns', () => { const columns = [ { id: 'a', display: 'First' }, @@ -236,7 +238,7 @@ describe('draggable columns', () => { cy.get('[data-popover-open]').should('not.exist'); // Should not interefere with column actions popover toggle - cy.wait(250); + cy.wait(WAIT_FOR_TRANSITION); cy.get('[data-test-subj=dataGridHeaderCellActionButton-a]').realClick(); cy.get('[data-popover-open]').should('have.focus'); cy.get('[data-test-subj=dataGridHeaderCellActionButton-a]').realClick(); @@ -247,7 +249,7 @@ describe('draggable columns', () => { cy.realMount(); cy.get('[data-test-subj=dataGridHeaderCell-a]').realHover(); - cy.wait(50); // wait until actions button transition is progressed enough for the button to be clickable + cy.wait(WAIT_FOR_TRANSITION); // wait until actions button transition is progressed enough for the button to be clickable cy.get('[data-test-subj=dataGridHeaderCellActionButton-a]').realClick(); cy.get('[data-popover-open]').should('have.focus'); @@ -297,7 +299,7 @@ describe('draggable columns', () => { ); cy.get('[data-test-subj=dataGridHeaderCell-a]').realHover(); - cy.wait(50); // wait until actions button transition is progressed enough for the button to be clickable + cy.wait(WAIT_FOR_TRANSITION); // wait until actions button transition is progressed enough for the button to be clickable cy.get('[data-test-subj=dataGridHeaderCellActionButton-a]').realClick(); cy.get('[data-popover-open]').should('have.focus');