From e0dc1b6959195afc9e2d68746470e3698bf17b2b Mon Sep 17 00:00:00 2001 From: Arturo Castillo Delgado Date: Fri, 17 Oct 2025 13:36:32 +0200 Subject: [PATCH 1/2] chore: update PR template --- .github/pull_request_template.md | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md index 3ff52a36d4c..6a82bf81950 100644 --- a/.github/pull_request_template.md +++ b/.github/pull_request_template.md @@ -49,7 +49,8 @@ Remove or strikethrough items that do not apply to your PR. - [ ] Added or updated **[jest](https://github.com/elastic/eui/blob/main/wiki/contributing-to-eui/testing/unit-testing.md) and [cypress](https://github.com/elastic/eui/blob/main/wiki/contributing-to-eui/testing/cypress-testing.md) tests** - [ ] Updated **[visual regression tests](https://github.com/elastic/eui/blob/main/wiki/contributing-to-eui/testing/visual-regression-testing.md)** - Release checklist - - [ ] A **[changelog](https://github.com/elastic/eui/blob/main/wiki/contributing-to-eui/documenting/changelogs.md)** entry exists and is marked appropriately. + - [ ] A **[changelog](https://github.com/elastic/eui/blob/main/wiki/contributing-to-eui/documenting/changelogs.md)** entry exists and is marked appropriately - [ ] If applicable, added the **breaking change** issue label (and filled out the breaking change checklist) + - [ ] If the changes unblock an issue in a different repo e.g. Kibana, smoke tested carefully - Designer checklist - [ ] If applicable, [file an issue](https://github.com/elastic/platform-ux-team/issues/new/choose) to update [EUI's Figma library](https://www.figma.com/community/file/964536385682658129) with any corresponding UI changes. _(This is an internal repo, if you are external to Elastic, ask a maintainer to submit this request)_ From bdd8acff4680dde5f5e932c969caa610de089528 Mon Sep 17 00:00:00 2001 From: Arturo Castillo Delgado Date: Mon, 20 Oct 2025 17:13:06 +0200 Subject: [PATCH 2/2] Add link --- .github/pull_request_template.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md index 6a82bf81950..c1dab06389d 100644 --- a/.github/pull_request_template.md +++ b/.github/pull_request_template.md @@ -51,6 +51,6 @@ Remove or strikethrough items that do not apply to your PR. - Release checklist - [ ] A **[changelog](https://github.com/elastic/eui/blob/main/wiki/contributing-to-eui/documenting/changelogs.md)** entry exists and is marked appropriately - [ ] If applicable, added the **breaking change** issue label (and filled out the breaking change checklist) - - [ ] If the changes unblock an issue in a different repo e.g. Kibana, smoke tested carefully + - [ ] If the changes unblock an issue in a different repo, smoke tested carefully (see [Testing EUI features in Kibana ahead of time](https://github.com/elastic/eui/blob/main/wiki/contributing-to-eui/testing/testing-in-kibana.md)) - Designer checklist - [ ] If applicable, [file an issue](https://github.com/elastic/platform-ux-team/issues/new/choose) to update [EUI's Figma library](https://www.figma.com/community/file/964536385682658129) with any corresponding UI changes. _(This is an internal repo, if you are external to Elastic, ask a maintainer to submit this request)_