Skip to content

Comments

[EuiPageHeaderContent] Ensure restrictWidth applies to children only usage#8965

Merged
mgadewoll merged 5 commits intoelastic:mainfrom
mgadewoll:pageheader/support-restrict-width-for-children-only
Aug 25, 2025
Merged

[EuiPageHeaderContent] Ensure restrictWidth applies to children only usage#8965
mgadewoll merged 5 commits intoelastic:mainfrom
mgadewoll:pageheader/support-restrict-width-for-children-only

Conversation

@mgadewoll
Copy link
Contributor

@mgadewoll mgadewoll commented Aug 13, 2025

Summary

This PR updates EuiPageHeaderContent and fixes the missing styles for restrictWidth when only custom content is passed via children.

This looks to be a bug and might have been missed. Without the restrictWidth styes applied, custom header content would not follow the same page context width.

Why are we making this change?

Fixing a missing styling.

Screenshots

EuiPageHeaderContent

before after
Screenshot 2025-08-13 at 11 11 31 Screenshot 2025-08-13 at 11 11 37

EuiPageTemplate

before after
Screenshot 2025-08-13 at 10 27 26 Screenshot 2025-08-13 at 10 27 38

Impact to users

🟢 There are no updates needed on consumer side.

QA

General checklist

  • Browser QA
    • Checked in both light and dark modes
    • Checked in both MacOS and Windows high contrast modes
    • Checked in mobile
    • Checked in Chrome, Safari, Edge, and Firefox
    • Checked for accessibility including keyboard-only and screenreader modes
  • Docs site QA
  • Code quality checklist
  • Release checklist
    • A changelog entry exists and is marked appropriately.
    • If applicable, added the breaking change issue label (and filled out the breaking change checklist)
  • Designer checklist
    • If applicable, file an issue to update EUI's Figma library with any corresponding UI changes. (This is an internal repo, if you are external to Elastic, ask a maintainer to submit this request)

@mgadewoll mgadewoll self-assigned this Aug 13, 2025
@mgadewoll mgadewoll force-pushed the pageheader/support-restrict-width-for-children-only branch from 2d3a181 to 36c802d Compare August 13, 2025 09:28
@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

History

cc @mgadewoll

@mgadewoll mgadewoll marked this pull request as ready for review August 13, 2025 09:46
@mgadewoll mgadewoll requested a review from a team as a code owner August 13, 2025 09:46
@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

cc @mgadewoll

@weronikaolejniczak weronikaolejniczak requested review from weronikaolejniczak and removed request for weronikaolejniczak August 13, 2025 10:42
@acstll acstll self-requested a review August 25, 2025 08:10
Copy link
Contributor

@acstll acstll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Changes look good and it works as expected. Tested in Storybook as suggested in the QA section. Thank you!

@mgadewoll mgadewoll merged commit fb5b0a0 into elastic:main Aug 25, 2025
6 checks passed
mgadewoll added a commit to elastic/kibana that referenced this pull request Aug 27, 2025
- `@elastic/eui`: `v106.3.0` ⏩ `v106.4.0`
- `@elastic/eui-theme-borealis`: `v3.3.1` ⏩ `v3.3.2`

[Questions? Please see our Kibana upgrade
FAQ.](https://github.com/elastic/eui/blob/main/wiki/eui-team-processes/upgrading-kibana.md#faq-for-kibana-teams)

## Package updates

## [`v106.4.0`](https://github.com/elastic/eui/releases/v106.4.0)

- Added prop `focusTrapProps` on `EuiModal`
([#8945](elastic/eui#8945))

**Bug fixes**

- Fixed the syntax of the SCSS variable `$euiColorTransparent` to ensure
a valid value ([#8966](elastic/eui#8966))
- Fixed `restrictWidth` not applying to `EuiPageHeaderContent` when only
`children` are used as content
([#8965](elastic/eui#8965))

**Accessibility**

- Fixed an issue where pressing Shift + Tab on the last tabbable element
inside `EuiInputPopover` popover would close the popover unexpectedly
([#8950](elastic/eui#8950))

### `@elastic/eui-theme-borealis`

## [`v3.3.2`](https://github.com/elastic/eui/releases/v3.3.2)

**Bug fixes**

- Fixed the syntax of the SCSS variable `$euiColorTransparent` to ensure
a valid value ([#8966](elastic/eui#8966))
arup-chauhan pushed a commit to arup-chauhan/eui that referenced this pull request Aug 29, 2025
kowalczyk-krzysztof pushed a commit to kowalczyk-krzysztof/kibana that referenced this pull request Aug 30, 2025
- `@elastic/eui`: `v106.3.0` ⏩ `v106.4.0`
- `@elastic/eui-theme-borealis`: `v3.3.1` ⏩ `v3.3.2`

[Questions? Please see our Kibana upgrade
FAQ.](https://github.com/elastic/eui/blob/main/wiki/eui-team-processes/upgrading-kibana.md#faq-for-kibana-teams)

## Package updates

## [`v106.4.0`](https://github.com/elastic/eui/releases/v106.4.0)

- Added prop `focusTrapProps` on `EuiModal`
([elastic#8945](elastic/eui#8945))

**Bug fixes**

- Fixed the syntax of the SCSS variable `$euiColorTransparent` to ensure
a valid value ([elastic#8966](elastic/eui#8966))
- Fixed `restrictWidth` not applying to `EuiPageHeaderContent` when only
`children` are used as content
([elastic#8965](elastic/eui#8965))

**Accessibility**

- Fixed an issue where pressing Shift + Tab on the last tabbable element
inside `EuiInputPopover` popover would close the popover unexpectedly
([elastic#8950](elastic/eui#8950))

### `@elastic/eui-theme-borealis`

## [`v3.3.2`](https://github.com/elastic/eui/releases/v3.3.2)

**Bug fixes**

- Fixed the syntax of the SCSS variable `$euiColorTransparent` to ensure
a valid value ([elastic#8966](elastic/eui#8966))
qn895 pushed a commit to qn895/kibana that referenced this pull request Sep 2, 2025
- `@elastic/eui`: `v106.3.0` ⏩ `v106.4.0`
- `@elastic/eui-theme-borealis`: `v3.3.1` ⏩ `v3.3.2`

[Questions? Please see our Kibana upgrade
FAQ.](https://github.com/elastic/eui/blob/main/wiki/eui-team-processes/upgrading-kibana.md#faq-for-kibana-teams)

## Package updates

## [`v106.4.0`](https://github.com/elastic/eui/releases/v106.4.0)

- Added prop `focusTrapProps` on `EuiModal`
([elastic#8945](elastic/eui#8945))

**Bug fixes**

- Fixed the syntax of the SCSS variable `$euiColorTransparent` to ensure
a valid value ([elastic#8966](elastic/eui#8966))
- Fixed `restrictWidth` not applying to `EuiPageHeaderContent` when only
`children` are used as content
([elastic#8965](elastic/eui#8965))

**Accessibility**

- Fixed an issue where pressing Shift + Tab on the last tabbable element
inside `EuiInputPopover` popover would close the popover unexpectedly
([elastic#8950](elastic/eui#8950))

### `@elastic/eui-theme-borealis`

## [`v3.3.2`](https://github.com/elastic/eui/releases/v3.3.2)

**Bug fixes**

- Fixed the syntax of the SCSS variable `$euiColorTransparent` to ensure
a valid value ([elastic#8966](elastic/eui#8966))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants