-
Notifications
You must be signed in to change notification settings - Fork 860
[Visual Refresh] Make EuiDataGrid and EuiTable hover consistent
#8769
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
28 commits
Select commit
Hold shift + click to select a range
1912704
feat(theme): add 2 new tokens
acstll 6109911
feat(table_row): improve background colors
acstll 6288956
feat(amsterdam): add tokens for borealis parity
acstll 95817b6
fix(amsterdam): table row component tokens
acstll c6de3a8
fix(data_grid_cell): focus and hover colors for outline
acstll 9f26a53
feat(data_grid): add 2 new component tokens
acstll efd14a7
feat(data_grid): adjust hover row styles to new design spec
acstll ce6aa83
feat(data_grid): do not apply hover styles for stripes
acstll 1c3c2a0
style: lint
acstll 99eaaea
docs(data_grid): update row classes demo
acstll 1cccf60
chore: changelogs
acstll 7ed4a46
test: update visual regression refs (EuiDataGrid)
acstll 0e62b61
fix(theme-borealis): value for primary90 in light mode
acstll d13f841
test(visual): update EuiDataGrid
acstll b634736
Revert "fix(theme-borealis): value for primary90 in light mode"
acstll cddc3dd
test(visual): update EuiDataGrid (after reverting ca2e5c3)
acstll 3a3bf43
feat(data_grid): add stripes styles using tokens
acstll 47d5fc1
test(cypress): data grid cell focus color
acstll e8c6717
chore: correct changelogs
acstll 69d558b
fix(amsterdam): token color values in JSON
acstll 55485c9
fix(amsterdam): undo changes to table row component tokens
acstll a81e48d
test(visual): update EuiDataGrid
acstll 76f8882
fix(amsterdam): token color values in JSON, for real
acstll 2332e54
docs: add tip admonition for data grid selected CSS class
acstll ea9e40f
chore: correct and better changelog messages
acstll f0cae73
nit: 1 CSS rule less
acstll 94c55b0
fix(theme): remove redundant dataGridRowBackgroundStriped token
acstll 0312e8a
style: lint, argh
acstll File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,15 @@ | ||
| - Added semantic tokens: | ||
| - `colors.backgroundBaseInteractiveSelectHover` | ||
| - `colors.borderStrongText` | ||
| - Added component tokens: | ||
| - `components.dataGridRowBackground` | ||
| - `components.dataGridRowBackgroundSelectHover` | ||
| - `components.dataGridRowStripesBackground` | ||
| - `components.dataGridRowStripesBackgroundHover` | ||
| - `components.dataGridRowStripesBackgroundStriped` | ||
| - `components.dataGridRowStripesBackgroundStripedHover` | ||
| - `components.dataGridRowStripesBackgroundSelect` | ||
| - `components.dataGridRowStripesBackgroundSelectHover` | ||
| - Updated values for tokens: | ||
| - `components.tableRowBackgroundSelectedHover` | ||
| - `components.tableRowInteractiveBackgroundFocus` |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| - Added types for | ||
| - `colors.backgroundBaseInteractiveSelectHover` | ||
| - `colors.borderStrongText` | ||
| - `components.dataGridRowBackground` | ||
| - `components.dataGridRowBackgroundSelectHover` | ||
| - `components.dataGridRowStripesBackground` | ||
| - `components.dataGridRowStripesBackgroundHover` | ||
| - `components.dataGridRowStripesBackgroundStriped` | ||
| - `components.dataGridRowStripesBackgroundStripedHover` | ||
| - `components.dataGridRowStripesBackgroundSelect` | ||
| - `components.dataGridRowStripesBackgroundSelectHover` |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file modified
BIN
+10 Bytes
(100%)
...eui/.loki/reference/chrome_desktop_Tabular_Content_EuiDataGrid_Cell_Actions.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+1 Byte
(100%)
...reference/chrome_desktop_Tabular_Content_EuiDataGrid_Cell_Expansion_Popover.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+1 Byte
(100%)
...i/.loki/reference/chrome_desktop_Tabular_Content_EuiDataGrid_Column_Actions.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+6 Bytes
(100%)
...loki/reference/chrome_desktop_Tabular_Content_EuiDataGrid_Draggable_Columns.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-146 Bytes
(100%)
...erence/chrome_desktop_Tabular_Content_EuiDataGrid_gridStyle_prop_Playground.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-12 Bytes
(100%)
...sktop_Tabular_Content_EuiDataGrid_toolbarVisibility_prop_Keyboard_Shortcuts.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-47 Bytes
(100%)
.../eui/.loki/reference/chrome_mobile_Tabular_Content_EuiDataGrid_Cell_Actions.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-2 Bytes
(100%)
.../reference/chrome_mobile_Tabular_Content_EuiDataGrid_Cell_Expansion_Popover.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+10 Bytes
(100%)
...ui/.loki/reference/chrome_mobile_Tabular_Content_EuiDataGrid_Column_Actions.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+5 Bytes
(100%)
....loki/reference/chrome_mobile_Tabular_Content_EuiDataGrid_Draggable_Columns.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-83 Bytes
(100%)
...ference/chrome_mobile_Tabular_Content_EuiDataGrid_gridStyle_prop_Playground.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| - Updated and aligned background hover styles for `EuiTable` and `EuiDataGrid` |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.