From c47441367a5fd0df535dd169425d6e749b8fe942 Mon Sep 17 00:00:00 2001 From: Weronika Olejniczak Date: Fri, 6 Jun 2025 18:09:44 +0200 Subject: [PATCH 1/5] feat(eui): remove xl size from EuiTabs --- packages/eui/src/components/tabs/tab.styles.ts | 7 ------- packages/eui/src/components/tabs/tabs.styles.ts | 3 --- packages/eui/src/components/tabs/tabs.tsx | 3 +-- 3 files changed, 1 insertion(+), 12 deletions(-) diff --git a/packages/eui/src/components/tabs/tab.styles.ts b/packages/eui/src/components/tabs/tab.styles.ts index 88ec2a47295..8550ccbe64e 100644 --- a/packages/eui/src/components/tabs/tab.styles.ts +++ b/packages/eui/src/components/tabs/tab.styles.ts @@ -99,12 +99,5 @@ export const euiTabContentStyles = (euiThemeContext: UseEuiTheme) => { (x, y) => x + y )}; `, - xl: css` - font-size: ${euiFontSize(euiThemeContext, 'l').fontSize}; - line-height: ${mathWithUnits( - [euiTheme.size.xxxl, euiTheme.size.s], - (x, y) => x + y - )}; - `, }; }; diff --git a/packages/eui/src/components/tabs/tabs.styles.ts b/packages/eui/src/components/tabs/tabs.styles.ts index 34016c64e36..c22458b24cf 100644 --- a/packages/eui/src/components/tabs/tabs.styles.ts +++ b/packages/eui/src/components/tabs/tabs.styles.ts @@ -39,8 +39,5 @@ export const euiTabsStyles = (euiThemeContext: UseEuiTheme) => { l: css` gap: ${euiTheme.size.l}; `, - xl: css` - gap: ${euiTheme.size.xl}; - `, }; }; diff --git a/packages/eui/src/components/tabs/tabs.tsx b/packages/eui/src/components/tabs/tabs.tsx index eaa0ca38edc..2ffa09d5efb 100644 --- a/packages/eui/src/components/tabs/tabs.tsx +++ b/packages/eui/src/components/tabs/tabs.tsx @@ -19,7 +19,7 @@ import { CommonProps } from '../common'; import { euiTabsStyles } from './tabs.styles'; import { EuiTabsContext } from './tabs_context'; -export const SIZES = ['s', 'm', 'l', 'xl'] as const; +export const SIZES = ['s', 'm', 'l'] as const; export type EuiTabsSizes = (typeof SIZES)[number]; export type EuiTabsProps = HTMLAttributes & @@ -40,7 +40,6 @@ export type EuiTabsProps = HTMLAttributes & bottomBorder?: boolean; /** * Sizes affect both font size and overall size. - * Only use the `xl` size when displayed as page titles. */ size?: EuiTabsSizes; }; From 55eb3a14890cb5cd99f928aca6c3c68c43d21864 Mon Sep 17 00:00:00 2001 From: Weronika Olejniczak Date: Fri, 6 Jun 2025 18:10:53 +0200 Subject: [PATCH 2/5] chore(eui): update snapshot tests --- .../page_header_content.test.tsx.snap | 12 +++++------ .../tabs/__snapshots__/tabs.test.tsx.snap | 21 ------------------- 2 files changed, 6 insertions(+), 27 deletions(-) diff --git a/packages/eui/src/components/page/page_header/__snapshots__/page_header_content.test.tsx.snap b/packages/eui/src/components/page/page_header/__snapshots__/page_header_content.test.tsx.snap index bc6ad9625b0..7abcf32e316 100644 --- a/packages/eui/src/components/page/page_header/__snapshots__/page_header_content.test.tsx.snap +++ b/packages/eui/src/components/page/page_header/__snapshots__/page_header_content.test.tsx.snap @@ -552,7 +552,7 @@ exports[`EuiPageHeaderContent props tabs is rendered 1`] = ` Tab 1
-
-`; - exports[`EuiTabs renders 1`] = `
Date: Fri, 6 Jun 2025 18:15:44 +0200 Subject: [PATCH 3/5] chore: add changelog --- packages/eui/changelogs/upcoming/8762.md | 3 +++ 1 file changed, 3 insertions(+) create mode 100644 packages/eui/changelogs/upcoming/8762.md diff --git a/packages/eui/changelogs/upcoming/8762.md b/packages/eui/changelogs/upcoming/8762.md new file mode 100644 index 00000000000..f22b20a9b52 --- /dev/null +++ b/packages/eui/changelogs/upcoming/8762.md @@ -0,0 +1,3 @@ +**Breaking changes** + +- Removed `xl` size from `EuiTabs` From 0f06acd96afeacb12c928a629a9aa592db65c623 Mon Sep 17 00:00:00 2001 From: Weronika Olejniczak Date: Tue, 10 Jun 2025 10:39:00 +0200 Subject: [PATCH 4/5] feat(eui): use l size for EuiTabs in EuiPageHeader --- .../src/components/page/page_header/page_header_content.tsx | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/packages/eui/src/components/page/page_header/page_header_content.tsx b/packages/eui/src/components/page/page_header/page_header_content.tsx index 1b534124ada..62cb21a2614 100644 --- a/packages/eui/src/components/page/page_header/page_header_content.tsx +++ b/packages/eui/src/components/page/page_header/page_header_content.tsx @@ -272,8 +272,6 @@ export const EuiPageHeaderContent: FunctionComponent< let tabsNode; if (tabs) { - const tabsSize: EuiTabsProps['size'] = pageTitle ? 'l' : 'xl'; - const renderTabs = () => { return tabs.map((tab, index) => { const { label, ...tabRest } = tab; @@ -302,7 +300,7 @@ export const EuiPageHeaderContent: FunctionComponent< <> {pageTitleNode && } {screenReaderPageTitle} - + {renderTabs()} From a042b8c87131b1fa9f89aa334a83801b709f736a Mon Sep 17 00:00:00 2001 From: Weronika Olejniczak Date: Tue, 10 Jun 2025 10:41:40 +0200 Subject: [PATCH 5/5] chore(eui): update EuiPageHeader snapshots --- .../__snapshots__/page_header_content.test.tsx.snap | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/packages/eui/src/components/page/page_header/__snapshots__/page_header_content.test.tsx.snap b/packages/eui/src/components/page/page_header/__snapshots__/page_header_content.test.tsx.snap index 7abcf32e316..bb303c77089 100644 --- a/packages/eui/src/components/page/page_header/__snapshots__/page_header_content.test.tsx.snap +++ b/packages/eui/src/components/page/page_header/__snapshots__/page_header_content.test.tsx.snap @@ -552,7 +552,7 @@ exports[`EuiPageHeaderContent props tabs is rendered 1`] = ` Tab 1