diff --git a/packages/eui/changelogs/upcoming/8626.md b/packages/eui/changelogs/upcoming/8626.md new file mode 100644 index 00000000000..234b6fbcb75 --- /dev/null +++ b/packages/eui/changelogs/upcoming/8626.md @@ -0,0 +1,3 @@ +**Dependency updates** + +- Updated `typescript` to v5.8.3 diff --git a/packages/eui/package.json b/packages/eui/package.json index ec56fd8492d..7e7fd92f342 100644 --- a/packages/eui/package.json +++ b/packages/eui/package.json @@ -248,7 +248,7 @@ "stylelint-config-standard": "^33.0.0", "stylelint-config-standard-scss": "^9.0.0", "terser-webpack-plugin": "^5.3.5", - "typescript": "4.5.3", + "typescript": "^5.8.3", "uglifyjs-webpack-plugin": "^2.2.0", "webpack": "^5.74.0", "webpack-cli": "^4.10.0", diff --git a/packages/eui/src/components/comment_list/comment_timeline.tsx b/packages/eui/src/components/comment_list/comment_timeline.tsx index 160fc0fb520..8de6463defd 100644 --- a/packages/eui/src/components/comment_list/comment_timeline.tsx +++ b/packages/eui/src/components/comment_list/comment_timeline.tsx @@ -56,5 +56,5 @@ export const EuiCommentTimeline: FunctionComponent = ({ ); } - return <>{iconRender}; + return <>{iconRender as ReactNode}; }; diff --git a/packages/eui/src/components/datagrid/body/header/draggable_columns.tsx b/packages/eui/src/components/datagrid/body/header/draggable_columns.tsx index be12c9a2669..74bea3c5943 100644 --- a/packages/eui/src/components/datagrid/body/header/draggable_columns.tsx +++ b/packages/eui/src/components/datagrid/body/header/draggable_columns.tsx @@ -257,7 +257,7 @@ export const ConditionalDroppableColumns: FunctionComponent< canDragAndDropColumns ? ( {children} ) : ( - <>{children} + <>{children as ReactNode} ) ); ConditionalDroppableColumns.displayName = 'ConditionalDroppableColumns'; diff --git a/packages/eui/src/components/form/field_password/field_password.tsx b/packages/eui/src/components/form/field_password/field_password.tsx index 84055bf38a8..ee99e245cbf 100644 --- a/packages/eui/src/components/form/field_password/field_password.tsx +++ b/packages/eui/src/components/form/field_password/field_password.tsx @@ -137,7 +137,9 @@ export const EuiFieldPassword: FunctionComponent = ( title={isVisible ? maskPasswordLabel : showPasswordLabel} disabled={disabled} {...dualToggleProps} - onClick={(e) => handleToggle(e, isVisible)} + onClick={(e: React.MouseEvent) => + handleToggle(e, isVisible) + } /> ); } diff --git a/packages/eui/src/services/accessibility/html_id_generator.test.tsx b/packages/eui/src/services/accessibility/html_id_generator.test.tsx index ca57d17aa8d..492e9ea241d 100644 --- a/packages/eui/src/services/accessibility/html_id_generator.test.tsx +++ b/packages/eui/src/services/accessibility/html_id_generator.test.tsx @@ -94,6 +94,7 @@ describe('useGeneratedHtmlId', () => { rerender({ conditionalId: 'world' }); expect(result.current).toEqual('world'); + // @ts-expect-error we need to assign `undefined` to assert the fallback rerender({ conditionalId: undefined }); expect(result.current).toBeTruthy(); // Should fall back to a generated ID }); diff --git a/yarn.lock b/yarn.lock index bf32c8d5665..070995d16e0 100644 --- a/yarn.lock +++ b/yarn.lock @@ -7488,7 +7488,7 @@ __metadata: tabbable: "npm:^5.3.3" terser-webpack-plugin: "npm:^5.3.5" text-diff: "npm:^1.0.1" - typescript: "npm:4.5.3" + typescript: "npm:^5.8.3" uglifyjs-webpack-plugin: "npm:^2.2.0" unified: "npm:^9.2.2" unist-util-visit: "npm:^2.0.3"