From bc2ed3bc993a46b66b484d9242f9da7a757385f9 Mon Sep 17 00:00:00 2001 From: Yerimar Date: Wed, 4 Dec 2024 23:27:32 -0400 Subject: [PATCH 1/7] [EuiCollapsibleNavBeta] Added aria-hidden=true to arrow button (#7353) --- .../accordion/accordion_trigger/accordion_trigger.tsx | 1 + .../__snapshots__/collapsible_nav_accordion.test.tsx.snap | 2 ++ .../__snapshots__/collapsible_nav_item.test.tsx.snap | 1 + 3 files changed, 4 insertions(+) diff --git a/packages/eui/src/components/accordion/accordion_trigger/accordion_trigger.tsx b/packages/eui/src/components/accordion/accordion_trigger/accordion_trigger.tsx index 9f0cc29efef..f5cd52a04b5 100644 --- a/packages/eui/src/components/accordion/accordion_trigger/accordion_trigger.tsx +++ b/packages/eui/src/components/accordion/accordion_trigger/accordion_trigger.tsx @@ -62,6 +62,7 @@ export const EuiAccordionTrigger: FunctionComponent< aria-controls={ariaControlsId} aria-expanded={isOpen} aria-labelledby={buttonId} + aria-hidden={buttonIsInteractive ? "true" : "false"} tabIndex={buttonIsInteractive ? -1 : 0} /> ); diff --git a/packages/eui/src/components/collapsible_nav_beta/collapsible_nav_item/__snapshots__/collapsible_nav_accordion.test.tsx.snap b/packages/eui/src/components/collapsible_nav_beta/collapsible_nav_item/__snapshots__/collapsible_nav_accordion.test.tsx.snap index fff981ec06d..85a06749e97 100644 --- a/packages/eui/src/components/collapsible_nav_beta/collapsible_nav_item/__snapshots__/collapsible_nav_accordion.test.tsx.snap +++ b/packages/eui/src/components/collapsible_nav_beta/collapsible_nav_item/__snapshots__/collapsible_nav_accordion.test.tsx.snap @@ -27,6 +27,7 @@ exports[`EuiCollapsibleNavAccordion renders as a sub item 1`] = ` - - -
-
- -`; - -exports[`EuiCollapsibleNav does not render if isOpen is false 1`] = `
`; - -exports[`EuiCollapsibleNav is rendered 1`] = ` -
-
-
-
- -
-
-
-
-`; - -exports[`EuiCollapsibleNav props accepts EuiFlyout props 1`] = ` -
-
-
- -
-
-
-`; - -exports[`EuiCollapsibleNav props button 1`] = ` -
- - -
-
-
-
-`; - -exports[`EuiCollapsibleNav props dockedBreakpoint 1`] = ` -
-
-
-
- -
-
-
-
-`; - -exports[`EuiCollapsibleNav props isDocked 1`] = ` -
-
-
-
-
-
-`; - -exports[`EuiCollapsibleNav props onClose 1`] = ` -
-
-
-
- -
-
-
-
-`; - -exports[`EuiCollapsibleNav props showButtonIfDocked 1`] = ` -
- - -
-
-
-
-`; diff --git a/packages/eui/src/components/collapsible_nav/collapsible_nav_group/__snapshots__/collapsible_nav_group.test.tsx.snap b/packages/eui/src/components/collapsible_nav/collapsible_nav_group/__snapshots__/collapsible_nav_group.test.tsx.snap index 7f6277f2a14..56faaf053ff 100644 --- a/packages/eui/src/components/collapsible_nav/collapsible_nav_group/__snapshots__/collapsible_nav_group.test.tsx.snap +++ b/packages/eui/src/components/collapsible_nav/collapsible_nav_group/__snapshots__/collapsible_nav_group.test.tsx.snap @@ -236,6 +236,7 @@ exports[`EuiCollapsibleNavGroup when isCollapsible is true accepts accordion pro + +
+
+
+
+`; + +exports[`EuiCollapsibleNav does not render if isOpen is false 1`] = `
`; + +exports[`EuiCollapsibleNav is rendered 1`] = ` +
+
+
+
+ +
+
+
+
+`; + +exports[`EuiCollapsibleNav props accepts EuiFlyout props 1`] = ` +
+
+
+ +
+
+
+`; + +exports[`EuiCollapsibleNav props button 1`] = ` +
+ + +
+
+
+
+`; + +exports[`EuiCollapsibleNav props dockedBreakpoint 1`] = ` +
+
+
+
+ +
+
+
+
+`; + +exports[`EuiCollapsibleNav props isDocked 1`] = ` +
+
+
+
+
+
+`; + +exports[`EuiCollapsibleNav props onClose 1`] = ` +
+
+
+
+ +
+
+
+
+`; + +exports[`EuiCollapsibleNav props showButtonIfDocked 1`] = ` +
+ + +
+
+
+
+`; From a717d80247a1b757fc53cfbc54322ccf954394cb Mon Sep 17 00:00:00 2001 From: Lene Gadewoll Date: Tue, 25 Feb 2025 09:33:34 +0100 Subject: [PATCH 7/7] chore: update changelog --- packages/eui/changelogs/upcoming/8236.md | 3 --- packages/eui/changelogs/upcoming/8342.md | 3 +++ 2 files changed, 3 insertions(+), 3 deletions(-) delete mode 100644 packages/eui/changelogs/upcoming/8236.md create mode 100644 packages/eui/changelogs/upcoming/8342.md diff --git a/packages/eui/changelogs/upcoming/8236.md b/packages/eui/changelogs/upcoming/8236.md deleted file mode 100644 index d6067d0e524..00000000000 --- a/packages/eui/changelogs/upcoming/8236.md +++ /dev/null @@ -1,3 +0,0 @@ -**Accessibility** - -- Improved the `EuiAccordionTrigger`'s screen reader UX. Passed `aria-hidden` to the `EuiAccordionArrow` to avoid duplicated announcements by screen readers. \ No newline at end of file diff --git a/packages/eui/changelogs/upcoming/8342.md b/packages/eui/changelogs/upcoming/8342.md new file mode 100644 index 00000000000..18d44f63680 --- /dev/null +++ b/packages/eui/changelogs/upcoming/8342.md @@ -0,0 +1,3 @@ +**Accessibility** + +- Improved the `EuiAccordionTrigger`'s screen reader UX by passed `aria-hidden` to the `EuiAccordionArrow` to avoid duplicated announcements by screen readers. \ No newline at end of file