Skip to content

[EuiFormRow] Fix hasEmptyLabelSpace being off by 2px #7380

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cee-chen merged 2 commits into from
Nov 21, 2023
Merged

[EuiFormRow] Fix hasEmptyLabelSpace being off by 2px #7380

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5e946ca
Fix `hasEmptyLabelSpace` being off by 2px
cee-chen Nov 21, 2023
e52c45b
changelog
cee-chen Nov 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions changelogs/upcoming/7380.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
**Bug fixes**

- Fixed `EuiFormRow`s with `hasEmptyLabelSpace` being very slightly off in vertical alignment
2 changes: 1 addition & 1 deletion src/components/form/form_row/_form_row.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
}

.euiFormRow--hasEmptyLabelSpace {
margin-top: floor($euiFontSize * $euiBodyLineHeight) + $euiSizeXS; /* 2 */
margin-top: $euiSize + $euiSizeXS; /* 2 */
// the following ensure that contents that aren't inherently the same height
// as inputs will align to the vertical center
min-height: $euiFormControlHeight;
Expand Down