Remove IE CSS utilities, mixins, and non-flex/sizing fallbacks #6154
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cee-chen
added
the
breaking change
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_6154/ |
1 similar comment
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_6154/ |
- word-wrap: not necessary for modern browsers - https://developer.mozilla.org/en-US/docs/Web/CSS/overflow-wrap - https://caniuse.com/wordwrap (despite the description, all modern browsers support overflow-wrap) - word-break: break-world: supported by all modern browsers (although it is noted as deprecated/not to be used): - https://developer.mozilla.org/en-US/docs/Web/CSS/word-break - https://caniuse.com/mdn-css_properties_word-break_break-word + Update EuiTable textOnly documentation: word-break works fine on FF
- Many consumers are overriding `width` instead of `flex-basis` at this point for the component, so changing it to flex-basis would cause unnecessary churn - `width` is also still valid and intuitive to use instead over flex-basis
- the fixed width affects modern browsers as well - add note of Kibana findings for Emotion conversion
cee-chen
force-pushed
the
remove-ie-css
branch
from
1fca4c2 to
26550b6
Compare
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_6154/ |
This was referenced Aug 23, 2022
elizabetdev
approved these changes
Aug 24, 2022
Contributor
elizabetdev
left a comment
elizabetdev
left a comment
There was a problem hiding this comment.
I looked at the code changes and LGTM! 🎉
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR is a follow-up to #6124, by removing the
_utility.scssfile completely (removing.euiIEFlexWrapFix) and removing theinternetExplorerOnly()mixin.This PR also removes several fairly innocuous IE fallbacks/workarounds. There are more in the codebase, but I decided to open multiple PRs rather than just one. The next PR will handle IE flex fallbacks/workarounds specifically, and a 3rd PR will handle IE fallbacks/workarounds in our JS code.
Components to QA
Checklist
- [ ] Props have proper autodocs and playground toggles- [ ] Added documentation- [ ] Checked Code Sandbox works for any docs examples- [ ] Added or updated jest and cypress tests- [ ] Checked for accessibility including keyboard-only and screenreader modes- [ ] Updated the Figma library counterpart