From 9eb97ff56e6d2cec0a82e57e48eb993270c70eea Mon Sep 17 00:00:00 2001 From: Constance Chen Date: Tue, 12 Jul 2022 09:44:38 -0700 Subject: [PATCH 1/2] Fix keyboard events not persisting to onChange callbacks --- src/components/selectable/selectable.tsx | 1 + 1 file changed, 1 insertion(+) diff --git a/src/components/selectable/selectable.tsx b/src/components/selectable/selectable.tsx index 2847962f531..ec66195277d 100644 --- a/src/components/selectable/selectable.tsx +++ b/src/components/selectable/selectable.tsx @@ -358,6 +358,7 @@ export class EuiSelectable extends Component< event.preventDefault(); event.stopPropagation(); if (this.state.activeOptionIndex != null && optionsList) { + event.persist(); // NOTE: This is needed for React v16 backwards compatibility optionsList.onAddOrRemoveOption( this.state.visibleOptions[this.state.activeOptionIndex], event From ef875e519c0f861d903090d9fbb8b00ac3688b48 Mon Sep 17 00:00:00 2001 From: Constance Chen Date: Tue, 12 Jul 2022 10:07:11 -0700 Subject: [PATCH 2/2] Changelog --- upcoming_changelogs/6045.md | 3 +++ 1 file changed, 3 insertions(+) create mode 100644 upcoming_changelogs/6045.md diff --git a/upcoming_changelogs/6045.md b/upcoming_changelogs/6045.md new file mode 100644 index 00000000000..e2b16b52ee0 --- /dev/null +++ b/upcoming_changelogs/6045.md @@ -0,0 +1,3 @@ +**Bug fixes** + +- Fixed `EuiSelectable` onChange keyboard events not being correctly passed back on React v16