diff --git a/CHANGELOG.md b/CHANGELOG.md index 47ae974fec5..dd71fc3e73c 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -5,6 +5,7 @@ - Fixed a `EuiDataGrid` sizing bug which didn't account for a horizontal scrollbar ([#5478](https://github.com/elastic/eui/pull/5478)) - Fixed a `EuiDatePicker` a11y bug where axe-core reported missing ARIA and role attributes ([#5501](https://github.com/elastic/eui/pull/5501)) - Fixed `EuiModalHeaderTitle` to conditionally wrap title strings in an H1 ([#5494](https://github.com/elastic/eui/pull/5494)) +- Fixed `EuiKeypadMenuItem` accessibility issue where there was a nested focusable element ([#5508](https://github.com/elastic/eui/pull/5508)) - Fixed a `EuiDataGrid` issue where a focused cell would lose focus when scrolled out of and back into view ([#5488](https://github.com/elastic/eui/pull/5488)) - Fixed an `EuiDatePicker` accessibility issue where `tabindex` was not applied to a listbox element ([#5509](https://github.com/elastic/eui/pull/5509)) diff --git a/src/components/badge/beta_badge/beta_badge.tsx b/src/components/badge/beta_badge/beta_badge.tsx index 5d04870c7e7..3d7e35810b5 100644 --- a/src/components/badge/beta_badge/beta_badge.tsx +++ b/src/components/badge/beta_badge/beta_badge.tsx @@ -224,7 +224,7 @@ export const EuiBetaBadge: FunctionComponent = ({ content={tooltipContent} title={title || label} > - + {icon || label} diff --git a/src/components/context_menu/__snapshots__/context_menu_panel.test.tsx.snap b/src/components/context_menu/__snapshots__/context_menu_panel.test.tsx.snap index f2acddc4b4a..1c2c8063de3 100644 --- a/src/components/context_menu/__snapshots__/context_menu_panel.test.tsx.snap +++ b/src/components/context_menu/__snapshots__/context_menu_panel.test.tsx.snap @@ -560,7 +560,7 @@ exports[`EuiContextMenuPanel props transitionDirection previous with transitionT exports[`EuiContextMenuPanel updating items and content updates to items should not re-render if any items's watchedItemProps did not change 1`] = ` " -
+
@@ -591,7 +591,7 @@ exports[`EuiContextMenuPanel updating items and content updates to items should exports[`EuiContextMenuPanel updating items and content updates to items should not re-render if any items's watchedItemProps did not change 2`] = ` " -
+
@@ -622,7 +622,7 @@ exports[`EuiContextMenuPanel updating items and content updates to items should exports[`EuiContextMenuPanel updating items and content updates to items should re-render at all times when children exists 1`] = ` " -
+
@@ -636,7 +636,7 @@ exports[`EuiContextMenuPanel updating items and content updates to items should exports[`EuiContextMenuPanel updating items and content updates to items should re-render at all times when children exists 2`] = ` " -
+
@@ -650,7 +650,7 @@ exports[`EuiContextMenuPanel updating items and content updates to items should exports[`EuiContextMenuPanel updating items and content updates to items should re-render if any items's watchedItemProps did change 1`] = ` " -
+
@@ -681,7 +681,7 @@ exports[`EuiContextMenuPanel updating items and content updates to items should exports[`EuiContextMenuPanel updating items and content updates to items should re-render if any items's watchedItemProps did change 2`] = ` " -
+
diff --git a/src/components/key_pad_menu/__snapshots__/key_pad_menu_item.test.tsx.snap b/src/components/key_pad_menu/__snapshots__/key_pad_menu_item.test.tsx.snap index c2bda9567db..91d633a5317 100644 --- a/src/components/key_pad_menu/__snapshots__/key_pad_menu_item.test.tsx.snap +++ b/src/components/key_pad_menu/__snapshots__/key_pad_menu_item.test.tsx.snap @@ -1,135 +1,187 @@ // Jest Snapshot v1, https://goo.gl/fbAQLP exports[`EuiKeyPadMenuItem checkable renders as checkbox 1`] = ` -