diff --git a/CHANGELOG.md b/CHANGELOG.md index 5c161b2431b..a754a65cbda 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -3,6 +3,7 @@ **Bug fixes** - Fixed a `EuiDataGrid` sizing bug which didn't account for a horizontal scrollbar ([#5478](https://github.com/elastic/eui/pull/5478)) +- Fixed `EuiModalHeaderTitle` to conditionally wrap title strings in an H1 ([#5494](https://github.com/elastic/eui/pull/5494)) **Deprecations** diff --git a/src/components/modal/__snapshots__/confirm_modal.test.tsx.snap b/src/components/modal/__snapshots__/confirm_modal.test.tsx.snap index cf1cddd9f35..5d50c0df403 100644 --- a/src/components/modal/__snapshots__/confirm_modal.test.tsx.snap +++ b/src/components/modal/__snapshots__/confirm_modal.test.tsx.snap @@ -47,7 +47,9 @@ Array [ class="euiModalHeader__title" data-test-subj="confirmModalTitleText" > - A confirmation modal +

+ A confirmation modal +

- A confirmation modal +

+ A confirmation modal +

- children +

+ children +

`; diff --git a/src/components/modal/modal_header_title.tsx b/src/components/modal/modal_header_title.tsx index 4c03a1ce5d5..c31475fce0e 100644 --- a/src/components/modal/modal_header_title.tsx +++ b/src/components/modal/modal_header_title.tsx @@ -22,7 +22,7 @@ export const EuiModalHeaderTitle: EuiModalHeaderTitleProps = ({ const classes = classnames('euiModalHeader__title', className); return (
- {children} + {React.isValidElement(children) ? children :

{children}

}
); };