Skip to content

[EuiDataGrid] Fix paginated & height-limited datagrids becoming unscrollable on rowCount change #5400

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cee-chen merged 4 commits into from
Nov 22, 2021
Merged

[EuiDataGrid] Fix paginated & height-limited datagrids becoming unscrollable on rowCount change #5400

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ceae152
[REVERT ME] Repro / testing
cee-chen Nov 22, 2021
cb9f462
Fix datagrids inside height-limited containers becoming unscrollable …
cee-chen Nov 22, 2021
8533b48
Add changelog entry
cee-chen Nov 22, 2021
de329e6
Revert "[REVERT ME] Repro / testing"
cee-chen Nov 22, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
## [`main`](https://github.com/elastic/eui/tree/main)

No public interface changes since `41.2.1`.
**Bug fixes**

- Fixed an `EuiDataGrid` bug where paginated overflowing data grids could become unscrollable when `rowCount` changed ([#5400](https://github.com/elastic/eui/pull/5400))

## [`41.2.1`](https://github.com/elastic/eui/tree/v41.2.1)

Expand Down
7 changes: 1 addition & 6 deletions src/components/datagrid/body/data_grid_body.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -596,11 +596,6 @@ export const EuiDataGridBody: FunctionComponent<EuiDataGridBodyProps> = (
makeRowManager(innerGridRef)
);

// reset height constraint when rowCount changes
useEffect(() => {
setHeight(undefined);
}, [rowCount]);

useEffect(() => {
const boundingRect = wrapperRef.current!.getBoundingClientRect();

Expand All @@ -610,7 +605,7 @@ export const EuiDataGridBody: FunctionComponent<EuiDataGridBodyProps> = (
if (boundingRect.width !== unconstrainedWidth) {
setWidth(boundingRect.width);
}
}, [unconstrainedHeight, wrapperDimensions, isFullScreen]);
}, [rowCount, unconstrainedHeight, wrapperDimensions, isFullScreen]);

const preventTabbing = useCallback((records: MutationRecord[]) => {
// multiple mutation records can implicate the same cell
Expand Down