From 4bc2a056374ce78542fc21646f3e081667604938 Mon Sep 17 00:00:00 2001 From: Constance Chen Date: Mon, 4 Oct 2021 16:46:08 -0700 Subject: [PATCH 1/3] Fix missing i18n token on default empty table message --- src/components/basic_table/basic_table.tsx | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/components/basic_table/basic_table.tsx b/src/components/basic_table/basic_table.tsx index a8e4ff2d4bc..024a856e65e 100644 --- a/src/components/basic_table/basic_table.tsx +++ b/src/components/basic_table/basic_table.tsx @@ -311,7 +311,9 @@ export class EuiBasicTable extends Component< static defaultProps = { responsive: true, tableLayout: 'fixed', - noItemsMessage: 'No items found', + noItemsMessage: ( + + ), }; static getDerivedStateFromProps( From 777de3397e94efe62474f8819570e616602dd748 Mon Sep 17 00:00:00 2001 From: Constance Chen Date: Mon, 4 Oct 2021 16:46:19 -0700 Subject: [PATCH 2/3] Update snapshots --- .../__snapshots__/basic_table.test.tsx.snap | 12 +- .../in_memory_table.test.tsx.snap | 126 +++++++++++++++--- 2 files changed, 118 insertions(+), 20 deletions(-) diff --git a/src/components/basic_table/__snapshots__/basic_table.test.tsx.snap b/src/components/basic_table/__snapshots__/basic_table.test.tsx.snap index 1c134126f7b..6bbb68528bd 100644 --- a/src/components/basic_table/__snapshots__/basic_table.test.tsx.snap +++ b/src/components/basic_table/__snapshots__/basic_table.test.tsx.snap @@ -312,7 +312,10 @@ exports[`EuiBasicTable empty is rendered 1`] = ` colSpan={1} isMobileFullWidth={true} > - No items found + @@ -1417,7 +1420,12 @@ exports[`EuiBasicTable with initial selection 1`] = ` }, ] } - noItemsMessage="No items found" + noItemsMessage={ + + } responsive={true} selection={ Object { diff --git a/src/components/basic_table/__snapshots__/in_memory_table.test.tsx.snap b/src/components/basic_table/__snapshots__/in_memory_table.test.tsx.snap index 4b92ccaea39..1dbfcfc7b44 100644 --- a/src/components/basic_table/__snapshots__/in_memory_table.test.tsx.snap +++ b/src/components/basic_table/__snapshots__/in_memory_table.test.tsx.snap @@ -71,7 +71,12 @@ exports[`EuiInMemoryTable behavior pagination 1`] = ` }, ] } - noItemsMessage="No items found" + noItemsMessage={ + + } onChange={[Function]} pagination={ Object { @@ -770,7 +775,12 @@ exports[`EuiInMemoryTable empty array 1`] = ` } data-test-subj="test subject string" items={Array []} - noItemsMessage="No items found" + noItemsMessage={ + + } onChange={[Function]} responsive={true} tableLayout="fixed" @@ -792,7 +802,12 @@ exports[`EuiInMemoryTable with executeQueryOptions 1`] = ` } data-test-subj="test subject string" items={Array []} - noItemsMessage="No items found" + noItemsMessage={ + + } onChange={[Function]} responsive={true} tableLayout="fixed" @@ -874,7 +889,12 @@ exports[`EuiInMemoryTable with initial selection 1`] = ` }, ] } - noItemsMessage="No items found" + noItemsMessage={ + + } onChange={[Function]} responsive={true} selection={ @@ -1422,7 +1442,12 @@ exports[`EuiInMemoryTable with initial sorting 1`] = ` }, ] } - noItemsMessage="No items found" + noItemsMessage={ + + } onChange={[Function]} responsive={true} sorting={ @@ -1468,7 +1493,12 @@ exports[`EuiInMemoryTable with items 1`] = ` }, ] } - noItemsMessage="No items found" + noItemsMessage={ + + } onChange={[Function]} responsive={true} tableLayout="fixed" @@ -1513,7 +1543,12 @@ exports[`EuiInMemoryTable with items and expanded item 1`] = ` }, ] } - noItemsMessage="No items found" + noItemsMessage={ + + } onChange={[Function]} responsive={true} tableLayout="fixed" @@ -1628,7 +1663,12 @@ exports[`EuiInMemoryTable with pagination 1`] = ` }, ] } - noItemsMessage="No items found" + noItemsMessage={ + + } onChange={[Function]} pagination={ Object { @@ -1670,7 +1710,12 @@ exports[`EuiInMemoryTable with pagination and default page size and index 1`] = }, ] } - noItemsMessage="No items found" + noItemsMessage={ + + } onChange={[Function]} pagination={ Object { @@ -1721,7 +1766,12 @@ exports[`EuiInMemoryTable with pagination and selection 1`] = ` }, ] } - noItemsMessage="No items found" + noItemsMessage={ + + } onChange={[Function]} pagination={ Object { @@ -1769,7 +1819,12 @@ exports[`EuiInMemoryTable with pagination, default page size and error 1`] = ` }, ] } - noItemsMessage="No items found" + noItemsMessage={ + + } onChange={[Function]} pagination={ Object { @@ -1819,7 +1874,12 @@ exports[`EuiInMemoryTable with pagination, hiding the per page options 1`] = ` }, ] } - noItemsMessage="No items found" + noItemsMessage={ + + } onChange={[Function]} pagination={ Object { @@ -1871,7 +1931,12 @@ exports[`EuiInMemoryTable with pagination, selection and sorting 1`] = ` }, ] } - noItemsMessage="No items found" + noItemsMessage={ + + } onChange={[Function]} pagination={ Object { @@ -1951,7 +2016,12 @@ exports[`EuiInMemoryTable with pagination, selection, sorting and simple search }, ] } - noItemsMessage="No items found" + noItemsMessage={ + + } onChange={[Function]} pagination={ Object { @@ -2025,7 +2095,12 @@ exports[`EuiInMemoryTable with pagination, selection, sorting and a single recor }, ] } - noItemsMessage="No items found" + noItemsMessage={ + + } onChange={[Function]} pagination={ Object { @@ -2085,7 +2160,12 @@ exports[`EuiInMemoryTable with pagination, selection, sorting and column rendere }, ] } - noItemsMessage="No items found" + noItemsMessage={ + + } onChange={[Function]} pagination={ Object { @@ -2174,7 +2254,12 @@ exports[`EuiInMemoryTable with pagination, selection, sorting and configured sea }, ] } - noItemsMessage="No items found" + noItemsMessage={ + + } onChange={[Function]} pagination={ Object { @@ -2258,7 +2343,12 @@ exports[`EuiInMemoryTable with search and component between search and table 1`] }, ] } - noItemsMessage="No items found" + noItemsMessage={ + + } onChange={[Function]} responsive={true} tableLayout="fixed" From d6628ae491ae5f3922d5bea831620c19bf195788 Mon Sep 17 00:00:00 2001 From: Constance Chen Date: Mon, 4 Oct 2021 16:49:28 -0700 Subject: [PATCH 3/3] Add changelog entry --- CHANGELOG.md | 1 + 1 file changed, 1 insertion(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index cd420ee7c0a..fc2d11604cf 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -8,6 +8,7 @@ - Fixed tick and level alignment in `Eui[Dual]Range` ([#5181](https://github.com/elastic/eui/pull/5181)) - Fixed duplicate IDs on mobile/desktop select all checkboxes in `EuiBasicTable` ([#5237](https://github.com/elastic/eui/pull/5237)) +- Fixed missing i18n token in `EuiBasicTable`'s no items message ([#5242](https://github.com/elastic/eui/pull/5242)) **Breaking changes**