Skip to content

[euiScreenReaderOnly] Use clip to fix scrolling issues caused by absolute positioning #5130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 2, 2021
Merged

[euiScreenReaderOnly] Use clip to fix scrolling issues caused by absolute positioning #5130

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
bbfc63c
Update .euiScreenReaderOnly to use clip
cee-chen Sep 2, 2021
1e7ea04
Add changelog entry
cee-chen Sep 2, 2021
d641f2d
[PR feedback] Add comment with more context
cee-chen Sep 2, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
## [`master`](https://github.com/elastic/eui/tree/master)

No public interface changes since `37.6.0`.
**Bug fixes**

- Fixed `EuiScreenReaderOnly` positioning issues within scrolling containers ([#5130](https://github.com/elastic/eui/pull/5130))

## [`37.6.0`](https://github.com/elastic/eui/tree/v37.6.0)

Expand Down
2 changes: 2 additions & 0 deletions src/global_styling/mixins/_helpers.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,6 +110,8 @@
position: absolute;
left: -10000px;
top: auto;
clip: rect(0 0 0 0);
clip-path: inset(50%);
width: 1px;
height: 1px;
overflow: hidden;
Expand Down