diff --git a/CHANGELOG.md b/CHANGELOG.md index 606ddb947d5..f8c8b540589 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,6 +1,8 @@ ## [`master`](https://github.com/elastic/eui/tree/master) -No public interface changes since `31.12.0`. +**Bug fixes** + +- Fixed `id` attribute to be unique across `EuiButtonGroupButton` elements ([#4657](https://github.com/elastic/eui/pull/4657)) ## [`31.12.0`](https://github.com/elastic/eui/tree/v31.12.0) diff --git a/src-docs/src/views/datagrid/styling.js b/src-docs/src/views/datagrid/styling.js index e4bf3337ed3..1d68669afa5 100644 --- a/src-docs/src/views/datagrid/styling.js +++ b/src-docs/src/views/datagrid/styling.js @@ -566,7 +566,7 @@ const DataGrid = () => { buttonSize="compressed" legend="Border" options={showColumnSelectorOptions} - idSelected={displayColumnSelector.toString()} + idSelected={displayColumnSelector ? 'true' : 'false'} onChange={onShowColumnSelectorChange} /> diff --git a/src/components/button/button_group/__snapshots__/button_group.test.tsx.snap b/src/components/button/button_group/__snapshots__/button_group.test.tsx.snap index 0d2dba2a90b..1f842553f42 100644 --- a/src/components/button/button_group/__snapshots__/button_group.test.tsx.snap +++ b/src/components/button/button_group/__snapshots__/button_group.test.tsx.snap @@ -17,7 +17,7 @@ exports[`EuiButtonGroup button props buttonSize compressed is rendered for multi aria-pressed="false" class="euiButtonGroupButton euiButtonGroupButton--text euiButtonGroupButton--small testClass1 testClass2" data-test-subj="test subject string" - id="button00" + id="generated-id" type="button" > @@ -119,7 +122,7 @@ exports[`EuiButtonGroup button props buttonSize compressed is rendered for singl