diff --git a/CHANGELOG.md b/CHANGELOG.md index 05158a97ece..1259fb7a4ad 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,6 +1,7 @@ ## [`master`](https://github.com/elastic/eui/tree/master) - Added `panelProps` to `EuiPopover` ([#4573](https://github.com/elastic/eui/pull/4573)) +- Updated the default of the `EuiPopover`s `ownFocus` prop from `false` to `true` ([#4551](https://github.com/elastic/eui/pull/4551)) **Bug fixes** diff --git a/src-docs/src/views/color_picker/color_palette_display.js b/src-docs/src/views/color_picker/color_palette_display.js index c0628131cb0..036a874a8d8 100644 --- a/src-docs/src/views/color_picker/color_palette_display.js +++ b/src-docs/src/views/color_picker/color_palette_display.js @@ -150,7 +150,6 @@ export default () => { diff --git a/src-docs/src/views/color_picker/containers.js b/src-docs/src/views/color_picker/containers.js index b96e0e90a01..0b706dbd8f8 100644 --- a/src-docs/src/views/color_picker/containers.js +++ b/src-docs/src/views/color_picker/containers.js @@ -95,7 +95,6 @@ export default () => { diff --git a/src-docs/src/views/combo_box/containers.js b/src-docs/src/views/combo_box/containers.js index 17043d45307..576229fa02f 100644 --- a/src-docs/src/views/combo_box/containers.js +++ b/src-docs/src/views/combo_box/containers.js @@ -143,7 +143,6 @@ export default () => { diff --git a/src-docs/src/views/datagrid/control_columns.js b/src-docs/src/views/datagrid/control_columns.js index 8cab3573658..71a0151766b 100644 --- a/src-docs/src/views/datagrid/control_columns.js +++ b/src-docs/src/views/datagrid/control_columns.js @@ -94,8 +94,7 @@ const SelectionButton = () => { selected } - closePopover={() => setIsPopoverOpen(false)} - ownFocus={true}> + closePopover={() => setIsPopoverOpen(false)}> {selectedRows.size} {selectedRows.size > 1 ? 'items' : 'item'} @@ -264,8 +263,7 @@ const trailingControlColumns = [ onClick={() => setIsPopoverOpen(!isPopoverOpen)} /> } - closePopover={() => setIsPopoverOpen(false)} - ownFocus={true}> + closePopover={() => setIsPopoverOpen(false)}> Actions
- -
+ + + + - +
diff --git a/src/components/datagrid/column_selector.tsx b/src/components/datagrid/column_selector.tsx index f67d06197bc..1efa878cba9 100644 --- a/src/components/datagrid/column_selector.tsx +++ b/src/components/datagrid/column_selector.tsx @@ -159,7 +159,6 @@ export const useDataGridColumnSelector = ( isOpen={isOpen} closePopover={() => setIsOpen(false)} anchorPosition="downLeft" - ownFocus panelPaddingSize="s" panelClassName="euiDataGridColumnSelectorPopover" button={ diff --git a/src/components/datagrid/column_sorting.tsx b/src/components/datagrid/column_sorting.tsx index 542e057181f..890d1562d61 100644 --- a/src/components/datagrid/column_sorting.tsx +++ b/src/components/datagrid/column_sorting.tsx @@ -141,7 +141,6 @@ export const useDataGridColumnSorting = ( isOpen={isOpen} closePopover={() => setIsOpen(false)} anchorPosition="downLeft" - ownFocus panelPaddingSize="s" panelClassName="euiDataGridColumnSortingPopover" button={ @@ -212,7 +211,6 @@ export const useDataGridColumnSorting = ( isOpen={avilableColumnsisOpen} closePopover={() => setAvailableColumnsIsOpen(false)} anchorPosition="downLeft" - ownFocus panelPaddingSize="none" button={ setIsOpen(false)} anchorPosition="downCenter" - ownFocus panelPaddingSize="s" panelClassName="euiDataGridColumnSelectorPopover" button={ diff --git a/src/components/date_picker/super_date_picker/date_popover/date_popover_button.tsx b/src/components/date_picker/super_date_picker/date_popover/date_popover_button.tsx index 918775d6a23..4da6acccebd 100644 --- a/src/components/date_picker/super_date_picker/date_popover/date_popover_button.tsx +++ b/src/components/date_picker/super_date_picker/date_popover/date_popover_button.tsx @@ -112,7 +112,6 @@ export const EuiDatePopoverButton: FunctionComponent anchorPosition={position === 'start' ? 'downLeft' : 'downRight'} display="block" panelPaddingSize="none" - ownFocus {...rest}> + anchorClassName="euiQuickSelectPopover__anchor">
diff --git a/src/components/header/header_links/header_links.tsx b/src/components/header/header_links/header_links.tsx index d2cea8054f5..2ae234b947f 100644 --- a/src/components/header/header_links/header_links.tsx +++ b/src/components/header/header_links/header_links.tsx @@ -138,7 +138,6 @@ export const EuiHeaderLinks: FunctionComponent = ({ @@ -153,16 +162,25 @@ exports[`EuiPopover props buffer 1`] = ` data-focus-lock-disabled="disabled" >