From 9a198b122c10752f904897380a2899f88bcb7af4 Mon Sep 17 00:00:00 2001 From: cchaos Date: Wed, 17 Feb 2021 16:58:18 -0500 Subject: [PATCH 1/2] Fixed disabled text styles in Safari (and iOS?) --- src/global_styling/mixins/_form.scss | 2 ++ src/global_styling/reset/_reset.scss | 4 ++++ src/themes/eui-amsterdam/global_styling/reset/_reset.scss | 4 ++++ 3 files changed, 10 insertions(+) diff --git a/src/global_styling/mixins/_form.scss b/src/global_styling/mixins/_form.scss index a217f6e5b68..4a22e9746b6 100644 --- a/src/global_styling/mixins/_form.scss +++ b/src/global_styling/mixins/_form.scss @@ -195,8 +195,10 @@ } @mixin euiFormControlDisabledStyle { + // sass-lint:disable-block no-vendor-prefixes cursor: not-allowed; color: $euiFormControlDisabledColor; + -webkit-text-fill-color: $euiFormControlDisabledColor; // Required for Safari background: $euiFormBackgroundDisabledColor; box-shadow: inset 0 0 0 1px $euiFormBorderDisabledColor; diff --git a/src/global_styling/reset/_reset.scss b/src/global_styling/reset/_reset.scss index 7efc6a4f17d..e4f8104bef2 100644 --- a/src/global_styling/reset/_reset.scss +++ b/src/global_styling/reset/_reset.scss @@ -104,6 +104,10 @@ a:hover, button, [role='button'] { input { margin: 0; padding: 0; + + &:disabled { + opacity: 1; /* required on iOS */ + } } button { diff --git a/src/themes/eui-amsterdam/global_styling/reset/_reset.scss b/src/themes/eui-amsterdam/global_styling/reset/_reset.scss index d50ae429834..6b03436f64c 100644 --- a/src/themes/eui-amsterdam/global_styling/reset/_reset.scss +++ b/src/themes/eui-amsterdam/global_styling/reset/_reset.scss @@ -110,6 +110,10 @@ a:hover, button, [role='button'] { input { margin: 0; padding: 0; + + &:disabled { + opacity: 1; /* required on iOS */ + } } button { From 7b3d9e9b293424d409e0791c34dc6d41b9368d25 Mon Sep 17 00:00:00 2001 From: cchaos Date: Wed, 17 Feb 2021 17:17:03 -0500 Subject: [PATCH 2/2] cl --- CHANGELOG.md | 1 + 1 file changed, 1 insertion(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 9c4e05d7338..22144c64164 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -9,6 +9,7 @@ - Fixed override possibility of text `color` in `EuiSideNavItem` ([#4488](https://github.com/elastic/eui/pull/4488)) - Fixed blurry animation of popovers in Chrome ([#4527](https://github.com/elastic/eui/pull/4527)) - Fixed styles of `disabled` times in `EuiDatePicker` ([#4524](https://github.com/elastic/eui/pull/4524)) +- Fixed `disabled` text color form fields in Safari ([#4538](https://github.com/elastic/eui/pull/4538)) **Theme: Amsterdam**