Skip to content

Minor and patch dependencies version updates #3967

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Sep 2, 2020
Merged

Minor and patch dependencies version updates #3967

merged 9 commits into from
Sep 2, 2020

Conversation

@thompsongl
Copy link
Contributor

@thompsongl thompsongl commented Aug 26, 2020 •
edited
Loading

Summary

Updates all dependencies where 'latest' is within the minor or patch range.

Exceptions:

  • react and co. will be a separate update (Remain on par with Kibana)
  • uuid was a safe major update
  • @types/react-beautiful-dnd should have been at v13 already

Any required changes will be noted inline.

Tested in Kibana

### Checklist

@thompsongl thompsongl added the dependencies PRs that update a dependency file label Aug 26, 2020
thompsongl
thompsongl commented Aug 26, 2020
View reviewed changes
thompsongl
thompsongl commented Aug 26, 2020
View reviewed changes
thompsongl
thompsongl commented Aug 26, 2020
View reviewed changes
@kibanamachine
Copy link

kibanamachine commented Aug 26, 2020

Preview documentation changes for this PR: https://eui.elastic.co/pr_3967/

@kibanamachine
Copy link

kibanamachine commented Aug 26, 2020

Preview documentation changes for this PR: https://eui.elastic.co/pr_3967/

@thompsongl thompsongl mentioned this pull request Aug 26, 2020
Closed
@thompsongl thompsongl marked this pull request as ready for review August 26, 2020 19:59
chandlerprall
chandlerprall suggested changes Aug 27, 2020
View reviewed changes
Copy link
Contributor

@chandlerprall chandlerprall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dependency & code changes look good, but yarn.lock changes can be cleaned up. I got about 1/3rd of the way through those changes before deciding a more automated approach can probably be cleaner/easier. I think https://github.com/atlassian/yarn-deduplicate might help?

@thompsongl
Copy link
Contributor Author

thompsongl commented Aug 27, 2020

I think https://github.com/atlassian/yarn-deduplicate might help?

Ah yep. Good call

@kibanamachine
Copy link

kibanamachine commented Aug 27, 2020

Preview documentation changes for this PR: https://eui.elastic.co/pr_3967/

@kibanamachine
Copy link

kibanamachine commented Aug 27, 2020

Preview documentation changes for this PR: https://eui.elastic.co/pr_3967/

@kibanamachine
Copy link

kibanamachine commented Aug 31, 2020

Preview documentation changes for this PR: https://eui.elastic.co/pr_3967/

@thompsongl thompsongl mentioned this pull request Sep 1, 2020
Merged
1 task
chandlerprall
chandlerprall approved these changes Sep 2, 2020
View reviewed changes
Copy link
Contributor

@chandlerprall chandlerprall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM!

@kibanamachine
Copy link

kibanamachine commented Sep 2, 2020

Preview documentation changes for this PR: https://eui.elastic.co/pr_3967/

@thompsongl thompsongl merged commit 66cb6aa into elastic:master Sep 2, 2020
@thompsongl thompsongl mentioned this pull request Sep 18, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@myasonik myasonik myasonik left review comments

@chandlerprall chandlerprall chandlerprall approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

dependencies PRs that update a dependency file

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@thompsongl @kibanamachine @chandlerprall @myasonik