Expand table's default action type to allow reactnode names #3688
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snide
reviewed
Jul 2, 2020
Contributor
snide
left a comment
snide
left a comment
There was a problem hiding this comment.
Functionally works. I think you might have a small docs issue
Contributor
Author
|
@snide updated the action's props table |
thompsongl
approved these changes
Jul 2, 2020
Contributor
thompsongl
left a comment
thompsongl
left a comment
There was a problem hiding this comment.
LGTM; tested locally with a more complex name element (tooltip like what ML will do)
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_3688/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Creates a work-around path for #3679 by expanding EuiBasicTable's default action's
nameto allow any React node.This does not fix the bug reported in #3679 where 3+ custom actions will trigger a React warning about nested button elements.
Checklist
- [ ] Check against all themes for compatibility in both light and dark modes- [ ] Checked in mobile- [ ] Checked in IE11 and Firefox- [ ] Props have proper autodocs- [ ] Added documentation- [ ] Checked Code Sandbox works for the any docs examples