[EuiFilterButton] Fix Amsterdam style #3591
Conversation
|
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
|
💚 CLA has been signed |
|
Welcome @phylim! Would you please sign the CLA linked below. Be sure to use the same email address linked to your Github account. |
|
Signed it and updated the PR based on your comments on the issue. |
cchaos
left a comment
cchaos
left a comment
There was a problem hiding this comment.
Thanks @phylim. There are a couple other best-practices we try to adhere to when making PR's.
- Add a description explanation of the path taken to solve the issue in the PR summary (even if it might be repeating a discussion that was had in the issue)
- Add before and after screenshots in the PR summary
- Even though this is a simple style fix, there are still checklist items that are appropriate which I have removed the strikethrough from. Please be sure to check these.
I will get Jenkins (our CI tool) to kick off a build and run the tests once those items above and the review comments have been addressed.
| @@ -0,0 +1,3 @@ | |||
| .euiButtonEmpty { | |||
There was a problem hiding this comment.
Unfortunately you can't apply the style this way because it will affect all EuiButtonEmpty instances not just the one created by the filter groups. You will need to target the custom class passed in EuiFilterButton called .euiFilterButton.
box-shadow looks different than form field. @cchaos said it would be fixed when SASS mixins are updated.
phyolim
force-pushed
the
amsterdam-filter-group
branch
from
9c59074 to
040aebf
Compare
remove border radius
|
Jenkins, test this |
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_3591/ |
|
@cchaos Thanks for your patience and details in explanations. |
cchaos
left a comment
cchaos
left a comment
There was a problem hiding this comment.
Not a problem, happy to have you contribute!
Just one more advice for how we use selectors.
Co-authored-by: Caroline Horn <[email protected]>
|
Jenkins, test this |
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_3591/ |
cchaos
changed the title
3 participants
Summary
before:
after:
fixes #3590
Checklist
- [ ] Checked in mobile- [ ] Props have proper autodocs- [ ] Added documentation- [ ] Checked Code Sandbox works for the any docs examples- [ ] Added or updated **[jest tests](https://github.com/elastic/eui/blob/master/wiki/testing.md)**- [ ] Checked for breaking changes and labeled appropriately- [ ] Checked for accessibility including keyboard-only and screenreader modes