From aee3720dd2d9147928ef98f33244a2f3714ffbdd Mon Sep 17 00:00:00 2001 From: walter-ind <52423075+walter-ind@users.noreply.github.com> Date: Mon, 30 Mar 2020 21:01:21 +0530 Subject: [PATCH 1/6] updated _select.scss --- src/components/form/select/_select.scss | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/src/components/form/select/_select.scss b/src/components/form/select/_select.scss index 26db7bbcebb..dc9aa5251d5 100644 --- a/src/components/form/select/_select.scss +++ b/src/components/form/select/_select.scss @@ -38,4 +38,10 @@ color: $euiTextColor; background: transparent; } + + &:-moz-focusring { + color: transparent; + text-shadow: 0 0 0 $euiColorFullShade; + } + } From eae4004354da6cdede4d32ac357b9cff61340ee6 Mon Sep 17 00:00:00 2001 From: walter-ind <52423075+walter-ind@users.noreply.github.com> Date: Mon, 30 Mar 2020 22:41:35 +0530 Subject: [PATCH 2/6] Update src/components/form/select/_select.scss Co-Authored-By: Caroline Horn <549577+cchaos@users.noreply.github.com> --- src/components/form/select/_select.scss | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/components/form/select/_select.scss b/src/components/form/select/_select.scss index dc9aa5251d5..0b25e197922 100644 --- a/src/components/form/select/_select.scss +++ b/src/components/form/select/_select.scss @@ -41,7 +41,7 @@ &:-moz-focusring { color: transparent; - text-shadow: 0 0 0 $euiColorFullShade; + text-shadow: 0 0 0 $euiTextColor; } } From 5891afb3b30c74808c973ce13444c8226610e734 Mon Sep 17 00:00:00 2001 From: walter-ind <52423075+walter-ind@users.noreply.github.com> Date: Mon, 30 Mar 2020 22:58:53 +0530 Subject: [PATCH 3/6] updated changelog.md --- CHANGELOG.md | 1 + 1 file changed, 1 insertion(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 8ab803bb303..411f528620f 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -8,6 +8,7 @@ **Bug Fixes** +- Fixed `outline of select box` appearing `in moz on focus` in EuiSelect - Fixed EuiBasicTable proptypes of itemId ([#3133](https://github.com/elastic/eui/pull/3133)) - Updated `EuiSuperDatePicker` to inherit the selected value in quick select ([#3105](https://github.com/elastic/eui/pull/3105)) From 8e63ff5fd6149ee21dce5a0c23e0484530715bef Mon Sep 17 00:00:00 2001 From: walter-ind <52423075+walter-ind@users.noreply.github.com> Date: Mon, 30 Mar 2020 23:01:14 +0530 Subject: [PATCH 4/6] Update CHANGELOG.md --- CHANGELOG.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 411f528620f..f9b1a00ed03 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -8,7 +8,7 @@ **Bug Fixes** -- Fixed `outline of select box` appearing `in moz on focus` in EuiSelect +- Fixed `outline of select box` appearing `in moz on focus` in EuiSelect ([#3197] (https://github.com/elastic/eui/pull/3197)) - Fixed EuiBasicTable proptypes of itemId ([#3133](https://github.com/elastic/eui/pull/3133)) - Updated `EuiSuperDatePicker` to inherit the selected value in quick select ([#3105](https://github.com/elastic/eui/pull/3105)) From 56ba063efc24715d61ce66260004fe8ce61f8fbb Mon Sep 17 00:00:00 2001 From: walter-ind <52423075+walter-ind@users.noreply.github.com> Date: Mon, 30 Mar 2020 23:06:29 +0530 Subject: [PATCH 5/6] Update _select.scss --- src/components/form/select/_select.scss | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/src/components/form/select/_select.scss b/src/components/form/select/_select.scss index 0b25e197922..80b46293835 100644 --- a/src/components/form/select/_select.scss +++ b/src/components/form/select/_select.scss @@ -40,8 +40,7 @@ } &:-moz-focusring { - color: transparent; - text-shadow: 0 0 0 $euiTextColor; - } - + color: transparent; + text-shadow: 0 0 0 $euiTextColor; + } } From 59a4676e5387258e3acc525e6385e9a5fabe163c Mon Sep 17 00:00:00 2001 From: Caroline Horn <549577+cchaos@users.noreply.github.com> Date: Mon, 30 Mar 2020 16:23:18 -0400 Subject: [PATCH 6/6] Update CHANGELOG.md --- CHANGELOG.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index f9b1a00ed03..cdefe94b704 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -8,7 +8,7 @@ **Bug Fixes** -- Fixed `outline of select box` appearing `in moz on focus` in EuiSelect ([#3197] (https://github.com/elastic/eui/pull/3197)) +- Removed outline of `EuiSelect` in Firefox ([#3197] (https://github.com/elastic/eui/pull/3197)) - Fixed EuiBasicTable proptypes of itemId ([#3133](https://github.com/elastic/eui/pull/3133)) - Updated `EuiSuperDatePicker` to inherit the selected value in quick select ([#3105](https://github.com/elastic/eui/pull/3105))