From 90d0afada5791659dbcb6ee3130018aad5817075 Mon Sep 17 00:00:00 2001 From: Greg Thompson Date: Fri, 31 Jan 2020 16:08:29 -0600 Subject: [PATCH 1/2] select ts cleanup --- src/components/form/select/index.d.ts | 34 --------------------------- src/components/form/select/index.ts | 2 +- 2 files changed, 1 insertion(+), 35 deletions(-) delete mode 100644 src/components/form/select/index.d.ts diff --git a/src/components/form/select/index.d.ts b/src/components/form/select/index.d.ts deleted file mode 100644 index 036e4b6c971..00000000000 --- a/src/components/form/select/index.d.ts +++ /dev/null @@ -1,34 +0,0 @@ -import { CommonProps } from '../../common'; - -import { - FunctionComponent, - ReactNode, - Ref, - OptionHTMLAttributes, - SelectHTMLAttributes, -} from 'react'; - -declare module '@elastic/eui' { - /** - * @see './select.js' - */ - - export type EuiSelectProps = CommonProps & - SelectHTMLAttributes & { - name?: string; - id?: string; - options: Array< - { text: ReactNode } & OptionHTMLAttributes - >; - isInvalid?: boolean; - fullWidth?: boolean; - isLoading?: boolean; - hasNoInitialSelection?: boolean; - inputRef?: Ref; - compressed?: boolean; - prepend?: ReactNode | ReactNode[]; - append?: ReactNode | ReactNode[]; - }; - - export const EuiSelect: FunctionComponent; -} diff --git a/src/components/form/select/index.ts b/src/components/form/select/index.ts index 3f3b8ef5562..911289c29b4 100644 --- a/src/components/form/select/index.ts +++ b/src/components/form/select/index.ts @@ -1 +1 @@ -export { EuiSelect } from './select'; +export { EuiSelect, EuiSelectProps } from './select'; From ec9ddc9deefbd2f0438fd6f7f3c3b985f516768e Mon Sep 17 00:00:00 2001 From: Greg Thompson Date: Fri, 31 Jan 2020 16:25:56 -0600 Subject: [PATCH 2/2] CL --- CHANGELOG.md | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 8fc8f3ebf15..32af433cfd5 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -5,6 +5,10 @@ - Changed SASS comments to non-compiled comments in invisibles files ([#2807](https://github.com/elastic/eui/pull/2807)) - Added `rowHeader` prop to `EuiBasicTable` to allow consumers to set the identifying cell in a row ([#2802](https://github.com/elastic/eui/pull/2802)) +**Bug fixes** + +- Exported missing `EuiSelectProps` type ([#2815](https://github.com/elastic/eui/pull/2815)) + ## [`18.3.0`](https://github.com/elastic/eui/tree/v18.3.0) - Converted `EuiModal` and `EuiConfirmModal` to TypeScript ([#2742](https://github.com/elastic/eui/pull/2742))