Commit c15d456
Constance
[Docs] Add support for
* Add new guide section TSX type
To be used as an extra code/source type indicator
* Update GuideSection components to pass tab type as a prop
* [extra] Destructure tab type from EuiTab
- so that it's not passed through ...rest
- this was accidentally incorrectly affecting the `<button type="">` output
+ it started generating typescript errors
* Update CodeSandboxLink to set the file extension based on the new passed `type` prop
- I originally thought about doing a conditional check for either JS or TSX, but I think this is the most future-proof way of being able to pass in whatever file type we need
- NOTE: We can't use plain `.ts` over `.tsx`, it will error on jsx tags
* Update erroring Tabs example to use TSX
(other tab examples should still be using JS, since we haven't specified that they need to be in TS)
* [Extra] Convert GuideSectionTypes to tsx
- so I can import it in other .tsx files without ts-ignoring
+ Update GuideSection to use its map reference directly instead of a static string (so it updates in multiple places if we update it in 1 place)
* Fix code block syntax highlighting for tsx
- totally missed this the first time, derp
- switched our `.toLowerCase` happening here instead of in `link.js`, which makes a bit more sense in terms of where it's needed
- added a = fallback for the type prop (can't make it required due to type shenanigans in guide_section_tabs.tsx), a fallback to JS seems to work fine instead
* [PR discussion] Update TS
Should only be used for demo code that contains Typescript that will break in JS files.tsx CodeSandbox demos (#5160)1 parent fddd21d commit c15d456
File tree
6 files changed
+33
-7
lines changed- src-docs/src
- components
- codesandbox
- guide_section
- guide_section_parts
- views/tabs
6 files changed
+33
-7
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
21 | 21 | | |
22 | 22 | | |
23 | 23 | | |
24 | | - | |
| 24 | + | |
25 | 25 | | |
26 | 26 | | |
27 | 27 | | |
| |||
44 | 44 | | |
45 | 45 | | |
46 | 46 | | |
| 47 | + | |
47 | 48 | | |
48 | 49 | | |
49 | 50 | | |
| |||
155 | 156 | | |
156 | 157 | | |
157 | 158 | | |
158 | | - | |
| 159 | + | |
159 | 160 | | |
160 | 161 | | |
161 | 162 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
16 | 16 | | |
17 | 17 | | |
18 | 18 | | |
| 19 | + | |
19 | 20 | | |
20 | 21 | | |
21 | 22 | | |
| |||
40 | 41 | | |
41 | 42 | | |
42 | 43 | | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
43 | 48 | | |
44 | 49 | | |
45 | 50 | | |
| |||
98 | 103 | | |
99 | 104 | | |
100 | 105 | | |
101 | | - | |
| 106 | + | |
102 | 107 | | |
103 | 108 | | |
104 | 109 | | |
| |||
Lines changed: 9 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
5 | 5 | | |
6 | 6 | | |
7 | 7 | | |
| 8 | + | |
8 | 9 | | |
9 | 10 | | |
10 | 11 | | |
| 12 | + | |
11 | 13 | | |
12 | 14 | | |
13 | 15 | | |
14 | 16 | | |
| 17 | + | |
15 | 18 | | |
16 | 19 | | |
17 | 20 | | |
| |||
26 | 29 | | |
27 | 30 | | |
28 | 31 | | |
| 32 | + | |
29 | 33 | | |
30 | 34 | | |
31 | 35 | | |
| |||
35 | 39 | | |
36 | 40 | | |
37 | 41 | | |
38 | | - | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
39 | 47 | | |
40 | 48 | | |
41 | 49 | | |
| |||
Lines changed: 13 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
59 | 59 | | |
60 | 60 | | |
61 | 61 | | |
62 | | - | |
| 62 | + | |
| 63 | + | |
| 64 | + | |
| 65 | + | |
| 66 | + | |
| 67 | + | |
| 68 | + | |
| 69 | + | |
| 70 | + | |
63 | 71 | | |
64 | 72 | | |
65 | 73 | | |
| |||
96 | 104 | | |
97 | 105 | | |
98 | 106 | | |
99 | | - | |
| 107 | + | |
| 108 | + | |
| 109 | + | |
| 110 | + | |
100 | 111 | | |
101 | 112 | | |
102 | 113 | | |
| |||
Lines changed: 1 addition & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | 2 | | |
| 3 | + | |
3 | 4 | | |
4 | 5 | | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
182 | 182 | | |
183 | 183 | | |
184 | 184 | | |
185 | | - | |
| 185 | + | |
186 | 186 | | |
187 | 187 | | |
188 | 188 | | |
| |||
0 commit comments