Skip to content

Commit afb91ea

Browse files
author
cchaos
committed
Merge branch 'k8/double_header' of https://github.com/cchaos/eui into k8/double_header
2 parents dd0153a + 50078a9 commit afb91ea

34 files changed

+1178
-740
lines changed

‎CHANGELOG.md‎

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,8 @@
11
## [`master`](https://github.com/elastic/eui/tree/master)
22

3-
**Theme: Amsterdam**
4-
5-
- Updated `EuiHeader` and components ([#3524](https://github.com/elastic/eui/pull/3524))
6-
73
**Breaking changes**
84

5+
- Improved `EuiPagination`, `EuiDataGrid`, `EuiBasicTable` and `EuiInMemoryTable` accessibility, causing `EuiPaginationButton` to require a new prop `pageIndex` ([#3294](https://github.com/elastic/eui/pull/3294))
96
- A fixed `EuiHeader` no longer automatically padding directly to the `<body>` element ([#3538](https://github.com/elastic/eui/pull/3538))
107

118
## [`24.1.0`](https://github.com/elastic/eui/tree/v24.1.0)
@@ -49,6 +46,7 @@
4946
- Improve `EuiOverlayMask` colors ([#3515](https://github.com/elastic/eui/pull/3515))
5047
- Updated shadow styles to improve smoothness, use black as the base color, and deprecated `opacity` value of shadow mixins ([#3428](https://github.com/elastic/eui/pull/3428))
5148
- Removed borders from `EuiFlyout` and `EuiPopover` ([#3477](https://github.com/elastic/eui/pull/3477))
49+
- Updated `EuiHeader` and components ([#3524](https://github.com/elastic/eui/pull/3524))
5250

5351
## [`24.0.0`](https://github.com/elastic/eui/tree/v24.0.0)
5452

‎src-docs/src/components/guide_page/guide_page_chrome.js‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -326,6 +326,7 @@ export class GuidePageChrome extends Component {
326326
toggleOpenOnMobile={this.toggleOpenOnMobile}
327327
isOpenOnMobile={this.state.isSideNavOpenOnMobile}
328328
items={sideNav}
329+
aria-label="Primary"
329330
/>
330331
);
331332
} else {

‎src-docs/src/views/datagrid/additional_controls.js‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,7 @@ export default () => {
5757

5858
return (
5959
<EuiDataGrid
60-
aria-label="Top EUI contributors"
60+
aria-label="Data grid demo with additional controls"
6161
columns={columns}
6262
columnVisibility={{
6363
visibleColumns: visibleColumns,

‎src-docs/src/views/datagrid/container.js‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,7 @@ export default () => {
5555
<EuiPanel style={{ width: 400, paddingBottom: 4 }} paddingSize="none">
5656
<div style={{ height: 300 }}>
5757
<EuiDataGrid
58-
aria-label="Top EUI contributors"
58+
aria-label="Container constrained data grid demo"
5959
columns={columns}
6060
columnVisibility={{
6161
visibleColumns: visibleColumns,

‎src-docs/src/views/datagrid/in_memory.js‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -119,7 +119,7 @@ export default () => {
119119

120120
return (
121121
<EuiDataGrid
122-
aria-label="Data grid demo"
122+
aria-label="inMemory level defaulting to undefined data grid demo"
123123
columns={columns}
124124
columnVisibility={{ visibleColumns, setVisibleColumns }}
125125
rowCount={raw_data.length}

‎src-docs/src/views/datagrid/in_memory_pagination.js‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -103,7 +103,7 @@ export default () => {
103103

104104
return (
105105
<EuiDataGrid
106-
aria-label="Data grid demo"
106+
aria-label="inMemory level set to pagination data grid demo"
107107
columns={columns}
108108
columnVisibility={{ visibleColumns, setVisibleColumns }}
109109
rowCount={raw_data.length}

‎src-docs/src/views/datagrid/in_memory_sorting.js‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -89,7 +89,7 @@ export default () => {
8989

9090
return (
9191
<EuiDataGrid
92-
aria-label="Data grid demo"
92+
aria-label="inMemory level set to sorting data grid demo"
9393
columns={columns}
9494
columnVisibility={{ visibleColumns, setVisibleColumns }}
9595
rowCount={raw_data.length}

‎src-docs/src/views/pagination/centered_pagination.js‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@ export default function() {
1818
<EuiFlexGroup justifyContent="spaceAround">
1919
<EuiFlexItem grow={false}>
2020
<EuiPagination
21+
aria-label="Centered pagination example"
2122
pageCount={PAGE_COUNT}
2223
activePage={activePage}
2324
onPageClick={activePage => goToPage(activePage)}

‎src-docs/src/views/pagination/customizable_pagination.js‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -85,6 +85,7 @@ export default () => {
8585

8686
<EuiFlexItem grow={false}>
8787
<EuiPagination
88+
aria-label="Custom pagination example"
8889
pageCount={PAGE_COUNT}
8990
activePage={activePage}
9091
onPageClick={goToPage}

‎src-docs/src/views/pagination/few_pages.js‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@ export default function() {
1212

1313
return (
1414
<EuiPagination
15+
aria-label="Few pages example"
1516
pageCount={PAGE_COUNT}
1617
activePage={activePage}
1718
onPageClick={activePage => goToPage(activePage)}

0 commit comments

Comments
 (0)