Removing unnecessary orientation enumerators

[nknize]

PR #8978 included 4 unnecessary enumeration values ('cw', 'clockwise', 'ccw', 'counterclockwise'). Since the ShapeBuilder.parse method handles these as strings and maps them to LEFT and RIGHT enumerators, respectively, their enumeration counterpart is unnecessary. This minor change adds 4 static convenience variables (COUNTER_CLOCKWISE, CLOCKWISE, CCW, CW) for purposes of the API and removes the unnecessary values from the Orientation Enum.

closes #9035

[rjernst]

I don't think this needs the string/boolean. They can be regular enum values. And the constants can be inside the enum, so that they can be used as if they were additional values.

[nknize]

Definitely doesn't require the string. The boolean is a bit trickier as it ripples through other places in the Geometry builder that is being refactored anyway in #8825.

[rjernst]

But you can replace wherever the boolean is used with equality to the enum value:

orientation.getValue() -> orientation == Orientation.RIGHT

[nknize]

Well not exactly. There's a boolean variable direction that needs to be the opposite whatever orientation is for inner ring arrays only. RIGHT/LEFT maps to false/true. So if orientation is RIGHT and we're dealing with an inner ring direction needs to be true. I went ahead and made the change, it just doesn't read as nicely as carrying the false/true bool with the enum.

[rjernst]

LGTM, just one last minor comment.

[nknize]

merged from 6d87284