diff --git a/x-pack/plugin/searchable-snapshots/src/internalClusterTest/java/org/elasticsearch/xpack/searchablesnapshots/BaseSearchableSnapshotsIntegTestCase.java b/x-pack/plugin/searchable-snapshots/src/internalClusterTest/java/org/elasticsearch/xpack/searchablesnapshots/BaseSearchableSnapshotsIntegTestCase.java index 50e91bec66942..c1f89eb4ea648 100644 --- a/x-pack/plugin/searchable-snapshots/src/internalClusterTest/java/org/elasticsearch/xpack/searchablesnapshots/BaseSearchableSnapshotsIntegTestCase.java +++ b/x-pack/plugin/searchable-snapshots/src/internalClusterTest/java/org/elasticsearch/xpack/searchablesnapshots/BaseSearchableSnapshotsIntegTestCase.java @@ -66,6 +66,7 @@ import static org.hamcrest.Matchers.equalTo; import static org.hamcrest.Matchers.greaterThanOrEqualTo; import static org.hamcrest.Matchers.instanceOf; +import static org.hamcrest.Matchers.is; import static org.hamcrest.Matchers.not; @ESIntegTestCase.ClusterScope(supportsDedicatedMasters = false, numClientNodes = 0) @@ -246,18 +247,18 @@ protected void assertShardFolders(String indexName, boolean snapshotDirectory) t translogExists ); assertThat( - snapshotDirectory ? "Snapshot directory doesn't exist" : "Snapshot directory shouldn't exist", - snapshotDirectory, - not(indexExists) + snapshotDirectory ? "Index file should not exist" : "Index file should exist", + indexExists, + not(snapshotDirectory) ); - assertTrue("Translog doesn't exist", translogExists); + assertThat("Translog should exist", translogExists, is(true)); try (Stream dir = Files.list(shardPath.resolveTranslog())) { final long translogFiles = dir.filter(path -> path.getFileName().toString().contains("translog")).count(); if (snapshotDirectory) { - assertEquals("There should be 2 translog files for a snapshot directory", 2L, translogFiles); + assertThat("There should be 2 translog files for a snapshot directory", translogFiles, equalTo(2L)); } else { assertThat( - "There should be 2+ translog files non a non-snapshot directory", + "There should be 2+ translog files for a non-snapshot directory", translogFiles, greaterThanOrEqualTo(2L) ); diff --git a/x-pack/plugin/searchable-snapshots/src/internalClusterTest/java/org/elasticsearch/xpack/searchablesnapshots/SearchableSnapshotsIntegTests.java b/x-pack/plugin/searchable-snapshots/src/internalClusterTest/java/org/elasticsearch/xpack/searchablesnapshots/SearchableSnapshotsIntegTests.java index ef40bfb20f944..3dc991d9bcb6a 100644 --- a/x-pack/plugin/searchable-snapshots/src/internalClusterTest/java/org/elasticsearch/xpack/searchablesnapshots/SearchableSnapshotsIntegTests.java +++ b/x-pack/plugin/searchable-snapshots/src/internalClusterTest/java/org/elasticsearch/xpack/searchablesnapshots/SearchableSnapshotsIntegTests.java @@ -68,6 +68,7 @@ import java.util.Map; import java.util.concurrent.BrokenBarrierException; import java.util.concurrent.CyclicBarrier; +import java.util.concurrent.TimeUnit; import java.util.stream.Collectors; import java.util.stream.IntStream; @@ -254,7 +255,7 @@ public void testCreateAndRestoreSearchableSnapshot() throws Exception { assertSearchableSnapshotStats(restoredIndexName, cacheEnabled, nonCachedExtensions); ensureGreen(restoredIndexName); - assertBusy(() -> assertShardFolders(restoredIndexName, true)); + assertBusy(() -> assertShardFolders(restoredIndexName, true), 30, TimeUnit.SECONDS); assertThat( client().admin()