-
Notifications
You must be signed in to change notification settings - Fork 25.6k
Recommend ssha256 cache hasher in FIPS docs
#87255
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 8 commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
6d3d80a
Recommend ssha256 for cache hasher in fips docs
n1v0lg dbc5a00
Tweak wording
n1v0lg 8b1ad9b
Tweaks
n1v0lg acf7da8
Space
n1v0lg 4b1ecd0
Mystery spaces
n1v0lg fc7acdb
Merge branch 'master' into docs/fips-cache-hasher
n1v0lg 10b0ed2
Tweak
n1v0lg 5bf9576
Spaces again
n1v0lg 66abced
Merge branch 'master' into docs/fips-cache-hasher
n1v0lg ce1f5f8
Split out sections
n1v0lg bde5064
Merge branch 'master' into docs/fips-cache-hasher
n1v0lg a1d6430
Address feedback
n1v0lg 5d23010
Merge branch 'master' into docs/fips-cache-hasher
n1v0lg 627e74a
Merge branch 'master' into docs/fips-cache-hasher
n1v0lg cc745f5
Update x-pack/docs/en/security/fips-140-compliance.asciidoc
n1v0lg 242097a
Update x-pack/docs/en/security/fips-140-compliance.asciidoc
n1v0lg 7d49ef9
Update x-pack/docs/en/security/fips-140-compliance.asciidoc
n1v0lg File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure we need this paragraph, and happy to remove it if we don't think it adds value. Essentially,
pbkdf2is a bad idea but it's not technically wrong and if a customer decides they want to use it and that the performance hit is acceptable, they can, from a FIPS standpoint. Wdyt?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this paragraph should go along with the previous one that says about
pbkdf2not suitable for caching hashing.