Add deprecation docs for cluster health HTTP code #79451
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DaveCTurner
added
>docs
elasticmachine
added
Team:Docs
Collaborator
|
Pinging @elastic/es-docs (Team:Docs) |
Collaborator
|
Pinging @elastic/es-distributed (Team:Distributed) |
Contributor
Author
|
We should really have added this in #78940. |
Documents the deprecation introduced in elastic#78180 and adjusted in elastic#79351.
DaveCTurner
force-pushed
the
2021-10-19-return_200_for_cluster_health_timeout-deprecation-docs
branch
from
8d644fc to
b123408
Compare
arteam
approved these changes
Oct 19, 2021
Contributor
|
That's is amazing, thank you very much, David! |
jrodewig
reviewed
Oct 19, 2021
| [%collapsible] | ||
| ==== | ||
| *Details* + | ||
| The <<cluster-health>> API includes options for waiting for certain health |
Contributor
There was a problem hiding this comment.
Drive-by comment: We can't use internal links (<<blah>>) in the migration guide. This will break when we reuse the docs in the Install and Upgrade Guide. We need to use external links instead.
Suggested change
| The <<cluster-health>> API includes options for waiting for certain health | |
| The {ref}/cluster-health.html[cluster health API] includes options for waiting for certain health |
Contributor
Author
There was a problem hiding this comment.
bah I clicked the button without seeing this, ok I'll fix
Contributor
There was a problem hiding this comment.
👍 Sorry for commenting so late! Thanks!
Contributor
Author
There was a problem hiding this comment.
I opened #79486 suggesting that this should fail the build.
DaveCTurner
deleted the
2021-10-19-return_200_for_cluster_health_timeout-deprecation-docs
branch
DaveCTurner
added a commit
to DaveCTurner/elasticsearch
that referenced
this pull request
Oct 19, 2021
In elastic#79451 we introduced an internal link in the migration guide, but this has to be an external link so that these docs can be re-used in the stack-wide guide too. This fixes that oversight.
DaveCTurner
added a commit
that referenced
this pull request
Oct 19, 2021
In #79451 we introduced an internal link in the migration guide, but this has to be an external link so that these docs can be re-used in the stack-wide guide too. This fixes that oversight.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Documents the deprecation introduced in #78180 and adjusted in #79351.