Skip to content

Compile fix for ValueFetcher and not used import in test #79045

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
pgomulka merged 1 commit into from
Oct 13, 2021
Merged

Compile fix for ValueFetcher and not used import in test #79045

pgomulka merged 1 commit into from
Oct 13, 2021

Conversation

@pgomulka
Copy link
Contributor

@pgomulka pgomulka commented Oct 13, 2021 •
edited
Loading

relates #78697
relates #78981

@pgomulka pgomulka requested a review from cbuescher October 13, 2021 10:36
@pgomulka pgomulka requested a review from markharwood October 13, 2021 10:36
@pgomulka pgomulka self-assigned this Oct 13, 2021
@pgomulka pgomulka added >non-issue >test Issues or PRs that are addressing/adding tests labels Oct 13, 2021
cbuescher
cbuescher approved these changes Oct 13, 2021
View reviewed changes
Copy link
Member

@cbuescher cbuescher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pgomulka pgomulka merged commit 394c0d1 into elastic:master Oct 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cbuescher cbuescher cbuescher approved these changes

+1 more reviewer

@markharwood markharwood markharwood approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

>non-issue >test Issues or PRs that are addressing/adding tests v8.0.0-beta1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@pgomulka @markharwood @cbuescher @jakelandis @elasticsearchmachine