Return 200 OK response code for a cluster health timeout #78968
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arteam
force-pushed
the
return-200-for-cluster-health-8.0
branch
2 times, most recently
from
33d4fb1 to
d157f81
Compare
arteam
force-pushed
the
return-200-for-cluster-health-8.0
branch
2 times, most recently
from
567ad8d to
af91a12
Compare
arteam
force-pushed
the
return-200-for-cluster-health-8.0
branch
from
af91a12 to
7e78762
Compare
arteam
added
the
:Distributed Indexing/CRUD
elasticmachine
added
the
Team:Distributed (Obsolete)
Collaborator
|
Pinging @elastic/es-distributed (Team:Distributed) |
arteam
changed the title
pgomulka
reviewed
Oct 13, 2021
server/src/main/java/org/elasticsearch/action/admin/cluster/health/ClusterHealthResponse.java
Outdated
Show resolved
Hide resolved
arteam
commented
Oct 13, 2021
server/src/main/java/org/elasticsearch/action/admin/cluster/health/ClusterHealthResponse.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/elasticsearch/action/admin/cluster/health/ClusterHealthResponse.java
Outdated
Show resolved
Hide resolved
Contributor
Author
|
@elasticmachine update branch |
arteam
added a commit
to arteam/elasticsearch
that referenced
this pull request
Nov 5, 2021
…ut parameter (elastic#80178) It will be deprecated in elastic#78968, but first we need to backport the allow_warning change to 7.16 and 8.0 in order to not break BWC
arteam
added a commit
to arteam/elasticsearch
that referenced
this pull request
Nov 5, 2021
…ut parameter (elastic#80178) It will be deprecated in elastic#78968, but first we need to backport the allow_warning change to 7.16 and 8.0 in order to not break BWC
… timeout with 200 response code" This reverts commit 64eb0df.
arteam
force-pushed
the
return-200-for-cluster-health-8.0
branch
from
392b663 to
05a2eea
Compare
arteam
added
the
auto-backport
Contributor
Author
|
@elasticmachine update branch |
arteam
added a commit
to arteam/elasticsearch
that referenced
this pull request
Nov 6, 2021
Returning 408 for a cluster health timeout was deprecated in elastic#78180 and backported to 7.x in elastic#78940 Now we can do a breaking change in 8.0 respecting the user choice to run ES in 7.x compatible mode via the REST Compatibility layer. Fixes elastic#70849
Collaborator
💚 Backport successful
|
Merged
9 tasks
arteam
added a commit
to arteam/elasticsearch
that referenced
this pull request
Nov 18, 2021
…stic#78968)" This reverts commit a2c3dae
arteam
added a commit
to arteam/elasticsearch
that referenced
this pull request
Nov 18, 2021
elastic#78968)" This reverts commit a2c3dae
arteam
added a commit
that referenced
this pull request
Nov 18, 2021
#78968)" (#80826) * [8.0] Revert "Return 200 OK response code for a cluster health timeout (#78968)" This reverts commit a2c3dae * Revert "Allow deprecation warning for the return_200_for_cluster_health_timeout parameter (#80178) (#80444)" This reverts commit 4102cf7. * Revert "Drop pre-7.2.0 wire format in ClusterHealthRequest (#79551)" This reverts commit b9fbe66. * Revert "Adjust the BWC version for the return200ForClusterHealthTimeout field (#79436)" This reverts commit f60bda5. * Revert "Use query param instead of a system property for opting in for new cluster health response code (#79351)" This reverts commit 8901a99 * Revert "Deprecate returning 408 for a server timeout on `_cluster/health` (#78180)" This reverts commit f266eb3 * Drop pre-7.2.0 wire format in ClusterHealthRequest (#79551) This reverts commit fa4d562. * Revert "[8.0] Disable BWC for #80821 (#80840)"
arteam
added a commit
that referenced
this pull request
Nov 18, 2021
)" (#80821) * Revert "Return 200 OK response code for a cluster health timeout (#78968)" This reverts commit a2c3dae * Revert "Allow deprecation warning for the return_200_for_cluster_health_timeout parameter (#80178)" This reverts commit 1c711e3. * Revert "Drop pre-7.2.0 wire format in ClusterHealthRequest (#79551)" This reverts commit b9fbe66. * Revert "Adjust the BWC version for the return200ForClusterHealthTimeout field (#79436)" This reverts commit f60bda5. * Revert "Use query param instead of a system property for opting in for new cluster health response code (#79351)" This reverts commit 8901a99 * Revert "Deprecate returning 408 for a server timeout on `_cluster/health` (#78180)" This reverts commit f266eb3 * Drop pre-7.2.0 wire format in ClusterHealthRequest (#79551) This reverts commit fa4d562 * Revert "Disable BWC for #80821 (#80839)" This reverts commit cb0e73e. Co-authored-by: Elastic Machine <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Returning 408 for a cluster health timeout was deprecated in #78180 and backported to 7.x in #78940
Now we can do a breaking change in 8.0 respecting the user choice to run ES in 7.x compatible mode via the REST Compatibility layer.
Fixes #70849