Use epoch_millis in can_match date range tests #77464
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnhatn
added
>test
Collaborator
|
Pinging @elastic/es-search (Team:Search) |
dnhatn
added
the
auto-backport
Member
Author
|
Thanks @cbuescher. |
dnhatn
added a commit
to dnhatn/elasticsearch
that referenced
this pull request
Sep 13, 2021
There is a known issue in 7.x where a date parameter of a range query can be interpreted as the number of years if no format is provided. This commit always uses epoch_millis format to avoid this issue in CanMatchPreFilterSearchPhaseTests. Relates elastic#63692 Closes elastic#77122
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a known issue in 7.x where a date parameter of a range query can be interpreted as the number of years if no format is provided. This commit always uses
epoch_millisformat to avoid this issue in CanMatchPreFilterSearchPhaseTests.Relates #63692
Closes #77122