Simplify test build output normalization #77172
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
breskeby
added
:Delivery/Build
breskeby
force-pushed
the
simplify-gradle-output-normalization
branch
from
cd51e16 to
e564c9c
Compare
Collaborator
|
Pinging @elastic/es-delivery (Team:Delivery) |
pugnascotia
reviewed
Sep 2, 2021
| import org.gradle.testkit.runner.TaskOutcome; | ||
| import org.gradle.testkit.runner.UnexpectedBuildFailure; | ||
| import org.gradle.testkit.runner.UnexpectedBuildSuccess; | ||
| import org.jetbrains.annotations.Nullable; |
Contributor
There was a problem hiding this comment.
We seem to use both this import and javax.annotation.Nullable. Do we have a "correct" one?
Contributor
Author
There was a problem hiding this comment.
I removed both. In general I avoid org.jetbrains.annotations.Nullable for sure. Sneaks in sometimes via code generators. Seems like I have to tweak my local setup
pugnascotia
approved these changes
Sep 2, 2021
breskeby
added
auto-backport-and-merge
auto-merge-without-approval
Collaborator
💔 Backport failed
To backport manually run |
breskeby
added a commit
to breskeby/elasticsearch
that referenced
this pull request
Sep 3, 2021
* Simplify test build output normalization
elasticsearchmachine
pushed a commit
that referenced
this pull request
Sep 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
always normalise output of gradle runner